Don't autogen schedule fields #1894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coolreader18
force-pushed
the
noa/no-autogen-sched-fields
branch
from
39e89e9 to
08b2fa0
Compare
coolreader18
force-pushed
the
noa/no-autogen-sched-fields
branch
from
08b2fa0 to
f53613f
Compare
gefjon
approved these changes
Nov 1, 2024
Contributor
gefjon
left a comment
gefjon
left a comment
There was a problem hiding this comment.
:excellent: Thanks for updating the test!
cloutiertyler
pushed a commit
that referenced
this pull request
Dec 11, 2024
Co-authored-by: Phoebe Goldman <phoebe@goldman-tribe.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Resolves #1818
API and ABI breaking changes
module API–breaking, but a very very easy fix (copy-paste from the error message into your code and it's fixed). was deemed an okay breakage for rc1->rc2, if that's what ends up happening.
Expected complexity level and risk
1