commitlog: Introduce epoch #1851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shubham8287
approved these changes
Oct 21, 2024
bfops
added
release-rc1
release-rc1-nice-to-have
backward-compatible
and removed
release-rc1
labels
cloutiertyler
approved these changes
Nov 5, 2024
Contributor
cloutiertyler
left a comment
cloutiertyler
left a comment
There was a problem hiding this comment.
This is fine by me, but could you please update the commitlog proposal as a way to document this change?
Adds a field `epoch` typed u64 to the commit header. It signifies the term number of the leader when writing to a commitlog in a distributed setting. It will help detecting and recovering from divergent logs, a situation which can arise during a leader failover.
kim
force-pushed
the
kim/commitlog/epoch
branch
from
b1bc229 to
996fcde
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a field
epochtyped u64 to the commit header. It signifies theterm number of the leader when writing to a commitlog in a distributed
setting.
It will help detecting and recovering from divergent logs, a situation
which can arise during a leader failover.