Jeremie/db connection type c# #1620
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcodes
force-pushed
the
jeremie/db-connection-type-c#
branch
from
64a3144 to
52d1bba
Compare
lcodes
force-pushed
the
jeremie/db-connection-type-c#
branch
from
52d1bba to
d2818e7
Compare
Contributor
Author
|
Moved to this PR #1682 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Expected complexity level and risk
3 - Rewrote the Module source generator, runtime module registration and removed the type registry.
Rationale is that by breaking tables types from table instances required fundamental changes in how the generator works and what code is emitted.
The new generator batches over all types at once and emits the full module description inside the Registration.cs generated file.
Testing
These must compile and pass the sdk test suite, for current features to keep working:
This one must compile for the new features to codegen properly: