Add backwards-compatible validation for RawModuleDefV8. #1606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazimuth
commented
Aug 16, 2024
2 tasks
kazimuth
force-pushed
the
jgilles/validation
branch
from
2dba1cf to
058f3d7
Compare
kazimuth
force-pushed
the
jgilles/v8validation
branch
4 times, most recently
from
c8465d8 to
af07662
Compare
kazimuth
force-pushed
the
jgilles/validation
branch
from
e1afd15 to
f695d0d
Compare
kazimuth
force-pushed
the
jgilles/v8validation
branch
from
af07662 to
de74b8d
Compare
Contributor
Author
|
@Centril @cloutiertyler I consider this ready for merge. |
kazimuth
force-pushed
the
jgilles/v8validation
branch
2 times, most recently
from
ab49537 to
a8e90e1
Compare
kazimuth
force-pushed
the
jgilles/v8validation
branch
from
a8e90e1 to
06a9e70
Compare
cloutiertyler
approved these changes
Aug 27, 2024
Contributor
cloutiertyler
left a comment
cloutiertyler
left a comment
There was a problem hiding this comment.
In principle this all seems fine to me.
Whoops, that didn't need to be there Placate clippy Paragraph comments Break tests, then fix them Address review comments + fix clippy Update to deal with accessor_name Fix import Update for removed structural_ty Add lifecycle validation Validate scheduled reducers, whoops
kazimuth
force-pushed
the
jgilles/v8validation
branch
from
3ad5756 to
8834292
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Plus unit and integration tests.
I'm still working through errors in the integration tests -- I think I'm going to need to something slightly more clever in a few places -- but generally this is ready for review.
API and ABI breaking changes
N/A
Expected complexity level and risk
This is tricky because we're adding a new code path that's supposed to replicate the behavior of another complex code path, but I think once we add the other end (ModuleDef -> TableSchema) comparing the results will be enough to validate that stuff works.
Testing
I test on both synthetic v8 module definitions and actual module definitions from the repo.