Skip to content

Remove row deduplication in incremental update #2397

@joshua-spacetime

Description

@joshua-spacetime

The server deduplicates rows for incremental join updates before sending the updated rows to the client.

/// Note, the 1.0 api does allow for duplicate rows.
/// Hence this may be removed at any time after 1.0.
pub fn eval_delta<'a, Tx: Datastore + DeltaStore>(

This is a bug.

It was necessary at the time it was introduced because the client SDKs did not handle duplicate rows. The SDKs were eventually updated to handle duplicate rows, but the deduplication on the server was never removed.

This has the potential to result in a corrupted SDK client cache for join subscriptions.

Metadata

Metadata

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions