Skip to content

Add support for DirectByteBuffers when encoding #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add support for DirectByteBuffers when encoding #42

wants to merge 1 commit into from

Conversation

luxbock
Copy link

@luxbock luxbock commented Oct 24, 2015

This feels a bit ugly but was the simplest way I came up with to address #41.

@KingMob
Copy link
Collaborator

KingMob commented Apr 11, 2022

@luxbock I'd support this, but I'd prefer an options map over a new parameter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luxbock @KingMob