Fix file descriptor leak in the digest method with a File argument. #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aking a File as an argument. I don't know how to write a test for the file descriptor leak -- without looking at a /proc filesystem, or parsing the output of lsof. I've tested this at the REPL and it works (and fixes a nasty file descriptor leak in my own program).
tebeka
added a commit
that referenced
this pull request
Nov 25, 2012
Fix file descriptor leak in the digest method with a File argument.
|
Merged, in 1.4.1. Thanks! |
tebeka
added a commit
that referenced
this pull request
Jun 16, 2016
Fix file descriptor leak in the digest method with a File argument.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wraps with-open around the FileInputStream constructor
in the digest method taking a File as an argument.