forked from open-telemetry/opentelemetry-go
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Global meter forwarding implementation (open-telemetry#392)
* Initial skeleton * Revert noop provider removal * Checkpoint * Checkpoint * Implement Bound instrument and LabelSet * Add test * Add a benchmark * Add a release test * Document LabelSetDelegator * Lint and comments * Add a second Meter test; fix typo; add a panic * Add a test for the builtin SDK * Address feedback
- Loading branch information
Showing
15 changed files
with
790 additions
and
30 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,102 @@ | ||
package internal_test | ||
|
||
import ( | ||
"context" | ||
"strings" | ||
"testing" | ||
|
||
"go.opentelemetry.io/otel/api/global" | ||
"go.opentelemetry.io/otel/api/global/internal" | ||
"go.opentelemetry.io/otel/api/key" | ||
"go.opentelemetry.io/otel/api/metric" | ||
export "go.opentelemetry.io/otel/sdk/export/metric" | ||
sdk "go.opentelemetry.io/otel/sdk/metric" | ||
"go.opentelemetry.io/otel/sdk/metric/aggregator/counter" | ||
"go.opentelemetry.io/otel/sdk/metric/aggregator/ddsketch" | ||
"go.opentelemetry.io/otel/sdk/metric/aggregator/gauge" | ||
"go.opentelemetry.io/otel/sdk/metric/aggregator/minmaxsumcount" | ||
) | ||
|
||
// benchFixture is copied from sdk/metric/benchmark_test.go. | ||
// TODO refactor to share this code. | ||
type benchFixture struct { | ||
sdk *sdk.SDK | ||
B *testing.B | ||
} | ||
|
||
var _ metric.Provider = &benchFixture{} | ||
|
||
func newFixture(b *testing.B) *benchFixture { | ||
b.ReportAllocs() | ||
bf := &benchFixture{ | ||
B: b, | ||
} | ||
bf.sdk = sdk.New(bf, sdk.NewDefaultLabelEncoder()) | ||
return bf | ||
} | ||
|
||
func (*benchFixture) AggregatorFor(descriptor *export.Descriptor) export.Aggregator { | ||
switch descriptor.MetricKind() { | ||
case export.CounterKind: | ||
return counter.New() | ||
case export.GaugeKind: | ||
return gauge.New() | ||
case export.MeasureKind: | ||
if strings.HasSuffix(descriptor.Name(), "minmaxsumcount") { | ||
return minmaxsumcount.New(descriptor) | ||
} else if strings.HasSuffix(descriptor.Name(), "ddsketch") { | ||
return ddsketch.New(ddsketch.NewDefaultConfig(), descriptor) | ||
} else if strings.HasSuffix(descriptor.Name(), "array") { | ||
return ddsketch.New(ddsketch.NewDefaultConfig(), descriptor) | ||
} | ||
} | ||
return nil | ||
} | ||
|
||
func (*benchFixture) Process(context.Context, export.Record) error { | ||
return nil | ||
} | ||
|
||
func (*benchFixture) CheckpointSet() export.CheckpointSet { | ||
return nil | ||
} | ||
|
||
func (*benchFixture) FinishedCollection() { | ||
} | ||
|
||
func (fix *benchFixture) Meter(name string) metric.Meter { | ||
return fix.sdk | ||
} | ||
|
||
func BenchmarkGlobalInt64CounterAddNoSDK(b *testing.B) { | ||
internal.ResetForTest() | ||
ctx := context.Background() | ||
sdk := global.MeterProvider().Meter("test") | ||
labs := sdk.Labels(key.String("A", "B")) | ||
cnt := sdk.NewInt64Counter("int64.counter") | ||
|
||
b.ResetTimer() | ||
|
||
for i := 0; i < b.N; i++ { | ||
cnt.Add(ctx, 1, labs) | ||
} | ||
} | ||
|
||
func BenchmarkGlobalInt64CounterAddWithSDK(b *testing.B) { | ||
// Comapare with BenchmarkInt64CounterAdd() in ../../sdk/meter/benchmark_test.go | ||
ctx := context.Background() | ||
fix := newFixture(b) | ||
|
||
sdk := global.MeterProvider().Meter("test") | ||
|
||
global.SetMeterProvider(fix) | ||
|
||
labs := sdk.Labels(key.String("A", "B")) | ||
cnt := sdk.NewInt64Counter("int64.counter") | ||
|
||
b.ResetTimer() | ||
|
||
for i := 0; i < b.N; i++ { | ||
cnt.Add(ctx, 1, labs) | ||
} | ||
} |
Oops, something went wrong.