Skip to content

Add support for Rails 6.0 and 6.1#39

Closed
crigor wants to merge 2 commits intoclio:masterfrom
crigor:rails-6-1
Closed

Add support for Rails 6.0 and 6.1#39
crigor wants to merge 2 commits intoclio:masterfrom
crigor:rails-6-1

Conversation

@crigor
Copy link

@crigor crigor commented Jan 5, 2021

This PR contains the following changes:

  • update_attributes was changed to update. update_attributes was deprecated on Rails 6.0 and removed from Rails 6.1.
  • For Rails 6.1 (but not 6.0), use :reflection instead of :association.
  • ActiveRecord::MigrationContext.new has changed starting Rails 6.0 and it now requires 2 arguments.

Tests pass when running rake test:all for rails 5.0, 5.1, 5.2, 6.0, and 6.1. Rails 4.2 is currently failing though it's the same error as in master.

@Aelphaeis
Copy link
Contributor

These changes were addressed first in #40 (6.0) and support for rails 6.1 was addressed in in #47.

Closing this pull request.

@Aelphaeis Aelphaeis closed this Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants