-
Notifications
You must be signed in to change notification settings - Fork 23
Description
Currently the plugin-check and plugin-worker packages relies on a couple Rollup plugins that are used in the Vite config (at runtime, meaning during the sde bundle/dev process). These don't actually need rollup when used via vite, but they still list rollup as a required peer dependency, which causes issues when installing via pnpm (see below).
hello-world campbell$ pnpm i
WARN deprecated rollup-plugin-inject@3.0.2: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-inject.
Already up-to-date
ERR_PNPM_PEER_DEP_ISSUES Unmet peer dependencies
.
└─┬ @sdeverywhere/plugin-check
├─┬ @rollup/plugin-node-resolve
│ ├── ✕ missing peer rollup@^2.42.0
│ └─┬ @rollup/pluginutils
│ └── ✕ missing peer rollup@^1.20.0||^2.0.0
└─┬ @rollup/plugin-replace
└── ✕ missing peer rollup@"^1.20.0 || ^2.0.0"
Peer dependencies that should be installed:
rollup@">=2.42.0 <3.0.0"
We may be able to avoid this by marking rollup as optional using peerDependenciesMeta.