deviation statement not yet support

[nowaits]

hi olof,
deviation is a very important feature but yet not support. Is there any plan for it?

[olofhagsand]

not-supported and add is now supported.

[olofhagsand]

Deviation now completed

[nowaits]

I tried deviation and find no effect with openconfig-system.yang, is there some error with it ?

   import openconfig-system { prefix oc-sys; }
  deviation /oc-sys:system/oc-sys:config/oc-sys:hostname {
    deviate not-supported;
  }

Following is the log:

May  5 20:40:45: filename2revision /home/dev/code/net-base/dist/script/../share/openconfig/models/system/openconfig-aaa.yang
May  5 20:40:45: yang_parse_filename /home/dev/code/net-base/dist/script/../share/openconfig/models/system/openconfig-aaa-types.yang
May  5 20:40:45: filename2revision /home/dev/code/net-base/dist/script/../share/openconfig/models/system/openconfig-aaa-types.yang
May  5 20:40:45: yang_parse_filename /home/dev/code/net-base/dist/script/../share/openconfig/models/system/openconfig-aaa-tacacs.yang
May  5 20:40:45: filename2revision /home/dev/code/net-base/dist/script/../share/openconfig/models/system/openconfig-aaa-tacacs.yang
May  5 20:40:45: yang_parse_filename /home/dev/code/net-base/dist/script/../share/openconfig/models/system/openconfig-aaa-radius.yang
May  5 20:40:45: filename2revision /home/dev/code/net-base/dist/script/../share/openconfig/models/system/openconfig-aaa-radius.yang
May  5 20:40:45: yang_parse_filename /home/dev/code/net-base/dist/script/../share/openconfig/models/system/openconfig-system-logging.yang
May  5 20:40:45: filename2revision /home/dev/code/net-base/dist/script/../share/openconfig/models/system/openconfig-system-logging.yang
May  5 20:40:45: yang_parse_filename /home/dev/code/net-base/dist/script/../share/openconfig/models/system/openconfig-system-management.yang
May  5 20:40:45: filename2revision /home/dev/code/net-base/dist/script/../share/openconfig/models/system/openconfig-system-management.yang
May  5 20:40:45: yang_parse_filename /home/dev/code/net-base/dist/script/../share/openconfig/models/system/openconfig-system-terminal.yang
May  5 20:40:45: filename2revision /home/dev/code/net-base/dist/script/../share/openconfig/models/system/openconfig-system-terminal.yang
May  5 20:40:45: yang_parse_filename /home/dev/code/net-base/dist/script/../share/openconfig/models/system/openconfig-procmon.yang
May  5 20:40:45: filename2revision /home/dev/code/net-base/dist/script/../share/openconfig/models/system/openconfig-procmon.yang
May  5 20:40:45: yang_parse_filename /home/dev/code/net-base/dist/script/../share/openconfig/models/system/openconfig-alarms.yang
May  5 20:40:45: filename2revision /home/dev/code/net-base/dist/script/../share/openconfig/models/system/openconfig-alarms.yang
May  5 20:40:45: yang_parse_filename /home/dev/code/net-base/dist/script/../share/openconfig/models/system/openconfig-alarm-types.yang
May  5 20:40:45: filename2revision /home/dev/code/net-base/dist/script/../share/openconfig/models/system/openconfig-alarm-types.yang
May  5 20:40:45: yang_parse_filename /home/dev/code/net-base/dist/script/../share/openconfig/models/platform/openconfig-platform.yang
May  5 20:40:45: filename2revision /home/dev/code/net-base/dist/script/../share/openconfig/models/platform/openconfig-platform.yang
May  5 20:40:45: yang_parse_filename /home/dev/code/net-base/dist/script/../share/openconfig/models/platform/openconfig-platform-types.yang
May  5 20:40:45: filename2revision /home/dev/code/net-base/dist/script/../share/openconfig/models/platform/openconfig-platform-types.yang
May  5 20:40:45: yang_parse_filename /home/dev/code/net-base/dist/script/../share/openconfig/models/system/openconfig-messages.yang
May  5 20:40:45: filename2revision /home/dev/code/net-base/dist/script/../share/openconfig/models/system/openconfig-messages.yang
May  5 20:40:45: yang_parse_filename /home/dev/code/net-base/dist/script/../share/openconfig/models/system/openconfig-license.yang
May  5 20:40:45: filename2revision /home/dev/code/net-base/dist/script/../share/openconfig/models/system/openconfig-license.yang
May  5 20:40:45: schema_nodeid_iterate: system not found

The test case is copied from : https://github.com/YangModels/yang/blob/master/vendor/cisco/nx/10.1-1/cisco-nx-openconfig-system-deviations.yang

[nowaits]

The follow config also get syntax error:

module example-deviations{
   yang-version 1.1;
   prefix md;
   namespace "urn:example:deviations";
   import example-base {
         prefix base;
   }
   deviation /base:system/base:daytime {
      deviate "not-supported";
   }
}

May  6 10:30:32: filename2revision example-deviations.yang
May  6 10:30:32: yang_parse_filename /home/dev/code/net-base/dist/script/../share/mgmt/modules/example-deviations.yang
May  6 10:30:32: clixon_yang_parseerror: 360: Yang error: /home/dev/code/net-base/dist/script/../share/mgmt/modules/example-deviations.yang on line 9: syntax error at or before: '"'
May  6 10:30:32: Yang error: /home/dev/code/net-base/dist/script/../share/mgmt/modules/example-deviations.yang on line 9
May  6 10:30:32: clixon_backend: 15276 Terminated retval:-1
May  6 10:30:32: backend_terminate
May  6 10:30:32: backend_terminate done

[olofhagsand]

@nowaits yes, the deviations were checked before uses/groups were expanded, and most openconfig constructs use that.
Please verify fixes.