Skip to content

Commit

Permalink
Fixed: [Schema Ambiguity Error with openconfig-system re: NTP](#334)
Browse files Browse the repository at this point in the history
  • Loading branch information
olofhagsand committed Jul 16, 2022
1 parent 1d78241 commit a846989
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 14 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ name: Clixon CI

on:
push:
branches: [ master, snmp ]
branches: [ master, callhome ]
pull_request:
branches: [ master, snmp ]
branches: [ master, callhome ]

jobs:
build:
Expand Down
11 changes: 5 additions & 6 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,10 @@
* [3.3.2](#332) Aug 27 2017
* [3.3.1](#331) June 7 2017

## SNMP branch
## 5.8.0
Planned: July 2022

### New features

* Clixon SNMP frontend
* Support of SNMP for retreiving and setting values via net-snmp using a MIB-YANG mapping defined in RFC6643.
Expand All @@ -49,11 +52,6 @@
* `--with-mib-generated-yang-dir=DIR`
* Thanks to Siklu Communications LTD for sponsoring this work

## 5.8.0
Planned: July 2022

### New features

* YANG Action (RFC 7950 Section 7.15)
* Register action callback with `action_callback_register()`, see main example
* Remains: check list keys, validate output
Expand Down Expand Up @@ -124,6 +122,7 @@ Developers may need to change their code

### Corrected Bugs

* Fixed: [Schema Ambiguity Error with openconfig-system re: NTP](https://github.com/clicon/clixon/issues/334)
* Fixed: [YANG mandatory statements within case nodes do not work](https://github.com/clicon/clixon/issues/344)
* Fixed: [Nested YANG choice does not work](https://github.com/clicon/clixon/issues/342)
* Fixed: [YANG if-feature does not support nested boolean expression](https://github.com/clicon/clixon/issues/341)
Expand Down
13 changes: 7 additions & 6 deletions apps/cli/cli_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -781,13 +781,14 @@ main(int argc,
/* Join rest of argv to a single command */
restarg = clicon_strjoin(argc, argv, " ");

/* If several cligen object variables match same preference, select first
* There is some unclarities if this should be set to 0 or 1.
* By default in CLIgen, it is 0
* It used to be 1 in Clixon. But see eg https://github.com/clicon/clixon/issues/330
* There may be cases where there will be "ambiguous".
/* Clixon hardcodes variable tie-breaks to non-terminals (2)
* There are cases in the autocli such as:
* (<string regexp:"r1" | <string regexp:"r2"){ ... }
* where r1 and r2 are regexps that overlap.
* Alterntaive is to add "preference" keyword in the CLIgen syntax that overrides this.
* Note there may be terminal tiebreaks liuke this which would motivate a setting to "3"?
*/
cligen_preference_mode_set(cli_cligen(h), 0);
cligen_preference_mode_set(cli_cligen(h), 2);

/* Call start function in all plugins before we go interactive
*/
Expand Down

0 comments on commit a846989

Please sign in to comment.