Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we get a new release to Pypi? #93

Closed
andy-maier opened this issue Mar 20, 2023 · 13 comments
Closed

Can we get a new release to Pypi? #93

andy-maier opened this issue Mar 20, 2023 · 13 comments
Assignees

Comments

@andy-maier
Copy link

Hello maintainers of this project. We'd like to use the recent updates for tab completion in some of our projects.

Could we please get a new release on Pypi (from the current master branch)?

@auvipy
Copy link
Collaborator

auvipy commented Mar 20, 2023

yes we should. @untitaker can you please take a look? or if you allow I might help

@untitaker
Copy link
Collaborator

untitaker commented Mar 20, 2023 via email

@GhostOps77
Copy link
Contributor

@auvipy @untitaker if you guys are gonna release this package, please make sure that you've merged this PR as well

Because these guys really need the python 2 support as well
also, don't forget to update the version number in the __init__.py file before release, in case you guys have forgot about that

@auvipy
Copy link
Collaborator

auvipy commented Mar 21, 2023

what's your user? i can add you to pypi

On Mon, Mar 20, 2023, at 18:16, Asif Saif Uddin wrote: yes we should. @untitaker https://github.com/untitaker can you please take a look? or if you allow I might help — Reply to this email directly, view it on GitHub <#93 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGMPRLRHFZ6DXHDRBXMT43W5CGHHANCNFSM6AAAAAAWBLCIXA. You are receiving this because you were mentioned.Message ID: @.***>

my pypi username is auvipy same as github and email auvipy@gmail.com same as github

@auvipy
Copy link
Collaborator

auvipy commented Mar 21, 2023

Could we please get a new release on Pypi (from the current master branch)?

do you need python 2.x support? it is long EOL now

@untitaker
Copy link
Collaborator

untitaker commented Mar 24, 2023 via email

@GhostOps77
Copy link
Contributor

GhostOps77 commented Mar 24, 2023

@untitaker @auvipy I would recommend not to release the module, especially until #92 is solved
Don't release it too soon

Also, I would like to be the maintainer for providing the python 2 support, but for that, I need to also setup a python2 test env in gh-actions, might take some time for me. It's pretty complicated to setup a python2 env in GHA

@untitaker
Copy link
Collaborator

untitaker commented Mar 24, 2023 via email

@GhostOps77
Copy link
Contributor

GhostOps77 commented Mar 25, 2023

@untitaker The issue that i've mentioned above (#92) has no relation to python2
I'm saying that this issue must be resolved, as i consider this one as a critical issue, as this affects the functionality of the REPL

And I also agree on your opinion on ignoring python 2, but I would like to implement the python 2 support for this module

@auvipy
Copy link
Collaborator

auvipy commented Mar 25, 2023

first you can help to fix that. but other then that there are many fixes that a new release can provide. as I have release access now, I can do regular releases now. so there is no need to worry. as for py 2, if it is not a big burden, I will accept that only for one release. but after that the support will be fully dropped.

@KSchopmeyer
Copy link

As andy said we would like a new release. However, we would very much like that this new release include the changes in tab-completion and tests for as much of this functionality as possible.

@auvipy
Copy link
Collaborator

auvipy commented Jun 9, 2023

please allow me some time. I will publish soon. got a new born baby less then 3 weeks ago. ping me again in nexxxt week please

@auvipy
Copy link
Collaborator

auvipy commented Jun 15, 2023

we got a new release in pypi now! please try and report if you face any issues.

@auvipy auvipy closed this as completed Jun 15, 2023
@auvipy auvipy self-assigned this Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants