Skip to content

Only successful installs should be cached #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2022
Merged

Only successful installs should be cached #281

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions src/common/clib-package.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1555,13 +1555,6 @@ int clib_package_install(clib_package_t *pkg, const char *dir, int verbose) {
}
#endif

#ifdef HAVE_PTHREADS
pthread_mutex_lock(&lock.mutex);
#endif
clib_cache_save_package(pkg->author, pkg->name, pkg->version, pkg_dir);
#ifdef HAVE_PTHREADS
pthread_mutex_unlock(&lock.mutex);
#endif

install:
if (pkg->configure) {
Expand All @@ -1582,6 +1575,16 @@ int clib_package_install(clib_package_t *pkg, const char *dir, int verbose) {
rc = clib_package_install_dependencies(pkg, dir, verbose);
}

if (0 == rc) {
#ifdef HAVE_PTHREADS
pthread_mutex_lock(&lock.mutex);
#endif
clib_cache_save_package(pkg->author, pkg->name, pkg->version, pkg_dir);
#ifdef HAVE_PTHREADS
pthread_mutex_unlock(&lock.mutex);
#endif
}

cleanup:
if (pkg_dir)
free(pkg_dir);
Expand Down