Skip to content

Logging future change in clib upgrade #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 15, 2020
Merged

Logging future change in clib upgrade #215

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9909202
Logging future change in #212
Isty001 Sep 14, 2020
c5d9cbb
Logging future change in #212
Isty001 Sep 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Logging future change in #212 
Logging if tag does not exist
Fixing unused tag option
  • Loading branch information
@Isty001
Isty001 committed Sep 14, 2020
commit 99092022bd56182d3c55f23482d29e533bb81b51
9 changes: 7 additions & 2 deletions src/clib-upgrade.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,11 +138,16 @@ static int install_package(const char *slug) {
if (0 != extended_slug) {
pkg = clib_package_new_from_slug(extended_slug, opts.verbose);
} else {
logger_warn("warn", "In clib 2.6.0, this functionality will change. We will default to the latest tag rather than the master branch.")
pkg = clib_package_new_from_slug(slug, opts.verbose);
}

if (NULL == pkg)
if (NULL == pkg) {
if (opts.tag) {
logger_error("error", "Unable to install tag %s. Please make sure it actually exists.", opts.tag);
}
return -1;
}

if (root_package && root_package->prefix) {
package_opts.prefix = root_package->prefix;
Expand Down Expand Up @@ -209,7 +214,7 @@ int main(int argc, char *argv[]) {
setopt_slug);
command_option(&program, "-T", "--tag <tag>",
"The tag to upgrade to (usually it is the latest)",
setopt_token);
setopt_tag);
#ifdef HAVE_PTHREADS
command_option(&program, "-C", "--concurrency <number>",
"Set concurrency (default: " S(MAX_THREADS) ")",
Expand Down