Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove obsolete Object.assign() polyfill #233

Merged
merged 1 commit into from
Aug 18, 2021
Merged

Remove obsolete Object.assign() polyfill #233

merged 1 commit into from
Aug 18, 2021

Conversation

ludofischer
Copy link
Contributor

cli-table3 can use Object.assign() directly since it targets Node.js 10+.

@ludofischer
chore: drop Object.assign() polyfill
2bb50d9 
cli-table3 can use Object.assign() directly since it targets Node.js 10+.
Turbo87
Turbo87 approved these changes Aug 18, 2021
View reviewed changes
Copy link
Contributor

@Turbo87 Turbo87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, looks like it's supported all the way down to Node.js 4.x 😅

Thanks :)

@Turbo87 Turbo87 added the enhancement New feature or request label Aug 18, 2021
@Turbo87 Turbo87 changed the title chore: drop Object.assign() polyfill Remove obsolete Object.assign() polyfill Aug 18, 2021
@Turbo87 Turbo87 merged commit 310f195 into cli-table:master Aug 18, 2021
@ludofischer ludofischer deleted the object-assign branch August 18, 2021 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Turbo87 Turbo87 Turbo87 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ludofischer @Turbo87