Add into_inner for wrapper types, and derive some more traits`
#52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Mar 21, 2025
|
Thanks for the review @scsmithr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by @scsmithr's comments #50 (review)
We now have date and decimal so called "newtype" wrappers around
i32/i64that allow formatting into a single locationRight now it is easy to go from
i32-> newtype, but not the other way aroundTypically, there is a function in rust programs
into_innerthat does the conversion.We could also consider adding
Fromimpls, but I think these functions are more explicit and we can add from impls laterI also added some more
derivetraits while I was at it