Switch mnist dataset mirror to a more reliable one #1201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current mnist dataset mirror used in the cleverhans_v3 sometimes sporadically return 503. This issue was first noted in 2018 (cleverhans-lab#496) and considered resolved since everything seem to be working fine since then. Yesterday, @orlp reported this issue again. I looked into it and it's quite sporadic, returning a 503 every once in a while. I thought it best to switch the url once and for all. Since we're using the "https://storage.googleapis.com/cvdf-datasets/mnist/" in our jax tutorial, I wanted to stay consistent with that and changed all referenced " http://yann.lecun.com/exdb/mnist/" to "https://storage.googleapis.com/cvdf-datasets/mnist/". This is the same url referenced in the tf datasets class.
|
You will need to resolve conflicts: are you working from the last commit? Could be easier to open a new PR if that’s not the case since this is 2 line diff |
|
Thanks, Nicolas - now resolved.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current mnist dataset mirror used in the cleverhans_v3 sometimes sporadically return 503. This issue was first noted in 2018 (#496) and considered resolved since everything seem to be working fine since then.
Yesterday, @orlp reported this issue again. I looked into it and it's quite sporadic, returning a 503 every once in a while. I thought it best to switch the url once and for all.
Since we're using the "https://storage.googleapis.com/cvdf-datasets/mnist/" in our jax tutorial, I wanted to stay consistent with that and changed all referenced " http://yann.lecun.com/exdb/mnist/" to "https://storage.googleapis.com/cvdf-datasets/mnist/". This is the same url referenced in the tf datasets class.