Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New testing setup #1192

Merged
merged 52 commits into from
Mar 16, 2021
Merged

New testing setup #1192

merged 52 commits into from
Mar 16, 2021

Conversation

steverab
Copy link
Collaborator

@steverab steverab commented Mar 1, 2021

This PR adds the new testing setup. Concretely, it adds automatically running

  • style checks for all code files
  • the PyTorch tests in cleverhans/future/torch/tests
  • the tutorials for PyTorch, TF2, and JAX

It also adds

  • requirements specifications in requirements
  • pre-commit hooks ensuring that a consistent code style is enforced for all contributors.

@steverab steverab marked this pull request as ready for review March 3, 2021 12:54
@alkaet alkaet self-requested a review March 3, 2021 15:51
@alkaet alkaet assigned alkaet, jonasguan and b-reckoner and unassigned alkaet Mar 3, 2021
@alkaet alkaet requested review from b-reckoner and jonasguan March 3, 2021 15:58
@alkaet
Copy link
Contributor

alkaet commented Mar 3, 2021

This is going to be a large commit to review. @jonasguan @b-reckoner Let's split up the testing for this one?

@jonasguan
Copy link
Collaborator

Sounds good @alkaet , I can start by spinning up a fresh Azure machine and follow the CONTRIBUTING.md guide to check everything works as expected for contributors. I likely won't have time until next week though.

Copy link
Collaborator

@jonasguan jonasguan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glorious

@tejuafonja tejuafonja merged commit 8c392b2 into cleverhans-lab:master Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants