Skip to content

chore(clerk-js): Add borders to color inputs #6116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2025
Merged

chore(clerk-js): Add borders to color inputs #6116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changeset/tangy-garlics-say.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
---
---
Comment on lines +1 to +2
Copy link
Contributor

@coderabbitai coderabbitai bot Jun 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Empty changeset file: missing content.

This changeset contains only the YAML delimiters without any summary or change type (patch, minor, or major). Please add a descriptive summary and specify the version bump type to ensure the release process picks up this change.

🤖 Prompt for AI Agents 
In the file .changeset/tangy-garlics-say.md at lines 1 to 2, the changeset is
empty with only YAML delimiters present. Add a descriptive summary of the change
and specify the version bump type (patch, minor, or major) between the
delimiters to properly document the change and enable the release process to
recognize it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The empty changeset is intentional. This PR doesn't affect any of the files included in released versions of the packages.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dstaley Got it—thanks for clarifying. An empty changeset is perfectly valid here as a “no-release” indicator, so no action needed. I’ll keep this convention in mind to avoid flagging it in future reviews. 🐇💡

✏️ Learnings added 
Learnt from: dstaley
PR: clerk/javascript#6116
File: .changeset/tangy-garlics-say.md:1-2
Timestamp: 2025-06-13T16:09:53.014Z
Learning: In the Clerk JavaScript repository, contributors create intentionally empty changeset files (containing only the YAML delimiters) when a PR touches only non-published parts of the codebase (e.g., sandbox assets). This signals that no package release is required, so such changesets should not be flagged as missing content.

Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.

12 changes: 12 additions & 0 deletions packages/clerk-js/sandbox/template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,6 +305,7 @@
<label class="flex items-center justify-between border-t border-gray-100 py-2">
<span class="font-mono text-xs">colorPrimary</span>
<input
class="border border-gray-200"
type="color"
id="colorPrimary"
value="#2F3037"
Expand All @@ -313,6 +314,7 @@
<label class="flex items-center justify-between border-t border-gray-100 py-2">
<span class="font-mono text-xs">colorNeutral</span>
<input
class="border border-gray-200"
type="color"
id="colorNeutral"
value="#000000"
Expand All @@ -321,6 +323,7 @@
<label class="flex items-center justify-between border-t border-gray-100 py-2">
<span class="font-mono text-xs">colorBackground</span>
<input
class="border border-gray-200"
type="color"
id="colorBackground"
value="#ffffff"
Expand All @@ -329,6 +332,7 @@
<label class="flex items-center justify-between border-t border-gray-100 py-2">
<span class="font-mono text-xs">colorTextOnPrimaryBackground</span>
<input
class="border border-gray-200"
type="color"
id="colorTextOnPrimaryBackground"
value="#ffffff"
Expand All @@ -337,6 +341,7 @@
<label class="flex items-center justify-between border-t border-gray-100 py-2">
<span class="font-mono text-xs">colorDanger</span>
<input
class="border border-gray-200"
type="color"
id="colorDanger"
value="#EF4444"
Expand All @@ -345,6 +350,7 @@
<label class="flex items-center justify-between border-t border-gray-100 py-2">
<span class="font-mono text-xs">colorSuccess</span>
<input
class="border border-gray-200"
type="color"
id="colorSuccess"
value="#22C543"
Expand All @@ -353,6 +359,7 @@
<label class="flex items-center justify-between border-t border-gray-100 py-2">
<span class="font-mono text-xs">colorWarning</span>
<input
class="border border-gray-200"
type="color"
id="colorWarning"
value="#F36B16"
Expand All @@ -361,6 +368,7 @@
<label class="flex items-center justify-between border-t border-gray-100 py-2">
<span class="font-mono text-xs">colorText</span>
<input
class="border border-gray-200"
type="color"
id="colorText"
value="#212126"
Expand All @@ -369,6 +377,7 @@
<label class="flex items-center justify-between border-t border-gray-100 py-2">
<span class="font-mono text-xs">colorTextSecondary</span>
<input
class="border border-gray-200"
type="color"
id="colorTextSecondary"
value="#747686"
Expand All @@ -377,6 +386,7 @@
<label class="flex items-center justify-between border-t border-gray-100 py-2">
<span class="font-mono text-xs">colorInputText</span>
<input
class="border border-gray-200"
type="color"
id="colorInputText"
value="#000000"
Expand All @@ -385,6 +395,7 @@
<label class="flex items-center justify-between border-t border-gray-100 py-2">
<span class="font-mono text-xs">colorInputBackground</span>
<input
class="border border-gray-200"
type="color"
id="colorInputBackground"
value="#ffffff"
Expand All @@ -393,6 +404,7 @@
<label class="flex items-center justify-between border-t border-gray-100 py-2">
<span class="font-mono text-xs">colorShimmer</span>
<input
class="border border-gray-200"
type="color"
id="colorShimmer"
value="#ffffff"
Expand Down
Loading