Skip to content

chore(repo): Pin non-breaking TanStack Start version in integration tests #6104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 11, 2025

Conversation

wobsoriano
Copy link
Member

@wobsoriano wobsoriano commented Jun 11, 2025

Description

TanStack Start introduced a breaking change that will be tackled in #5973. This PR ensures that the integration tests will always resolve to a compatible set of TanStack Router/Start versions.

See my comment in this TanStack issue

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Chores
    • Updated several dependencies to use exact version numbers instead of version ranges, ensuring consistent installations across environments.
    • Added an empty changeset file for tracking future changes.

Copy link

changeset-bot bot commented Jun 11, 2025

🦋 Changeset detected

Latest commit: 1e2a2ca

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jun 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 11, 2025 5:17pm

Copy link
Contributor

coderabbitai bot commented Jun 11, 2025

📝 Walkthrough

Walkthrough

This update pins several dependencies in package.json files to exact versions by replacing caret (^) ranges with specific version numbers and adds new dependencies at exact versions. Additionally, an empty changeset file was added to the .changeset directory. No changes were made to exported or public entities.

Changes

Files Change Summary
integration/templates/tanstack-react-router/package.json Updated dependency versions for "@tanstack/react-router", "@tanstack/react-router-devtools", and "@tanstack/router-plugin" from caret ranges to exact "1.120.17"; added "@tanstack/router-generator" at version "1.120.17".
integration/templates/tanstack-react-start/package.json Updated dependency versions for multiple "@TanStack" packages from caret ranges or older exact versions to exact "1.120.17"; added several new "@TanStack" packages at version "1.120.17".
packages/tanstack-react-start/package.json Changed devDependency versions for "@tanstack/react-router" and "@tanstack/react-start" from caret ranges to exact versions ("1.115.2").
.changeset/green-peaches-sneeze.md Added an empty changeset file containing only frontmatter delimiters with no content.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 448aa96 and 1e2a2ca.

📒 Files selected for processing (2)
  • integration/templates/tanstack-react-router/package.json (1 hunks)
  • integration/templates/tanstack-react-start/package.json (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • integration/templates/tanstack-react-router/package.json
⏰ Context from checks skipped due to timeout of 90000ms (5)
  • GitHub Check: Formatting | Dedupe | Changeset
  • GitHub Check: Build Packages
  • GitHub Check: semgrep/ci
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: Analyze (actions)
🔇 Additional comments (1)
integration/templates/tanstack-react-start/package.json (1)

11-20:

✅ Verification successful

Verify pinned @TanStack package versions
Ensure all listed @tanstack packages are published at 1.120.17 on npm and that this template stays in sync with others.


🏁 Script executed:

#!/bin/bash
packages=(
  "@tanstack/react-router@1.120.17"
  "@tanstack/router-generator@1.120.17"
  "@tanstack/react-router-devtools@1.120.17"
  "@tanstack/react-start@1.120.17"
  "@tanstack/react-start-config@1.120.17"
  "@tanstack/router-plugin@1.120.17"
  "@tanstack/react-start-client@1.120.17"
  "@tanstack/react-start-plugin@1.120.17"
  "@tanstack/react-start-server@1.120.17"
  "@tanstack/start-server-core@1.120.17"
)
for pkg in "${packages[@]}"; do
  if ! npm view "$pkg" version &>/dev/null; then
    echo "$pkg not found on npm"
  else
    echo "✔️ $pkg exists"
  fi
done

Length of output: 2260


Pinned @TanStack packages verified successfully
All ten @tanstack packages are published at v1.120.17 on npm. No changes required here—just remember to bump these versions in lockstep across all related templates going forward.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

pkg-pr-new bot commented Jun 11, 2025

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@6104

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@6104

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@6104

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@6104

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@6104

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@6104

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@6104

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@6104

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@6104

@clerk/express

npm i https://pkg.pr.new/@clerk/express@6104

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@6104

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@6104

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@6104

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@6104

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@6104

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@6104

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@6104

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@6104

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@6104

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@6104

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@6104

@clerk/types

npm i https://pkg.pr.new/@clerk/types@6104

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@6104

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@6104

commit: 1e2a2ca

@wobsoriano wobsoriano changed the title chore(repo): Pin TanStack Start versions to avoid breaking changes chore(repo): Fix TanStack Start integration tests Jun 11, 2025
@wobsoriano wobsoriano changed the title chore(repo): Fix TanStack Start integration tests chore(repo): Pin non-breaking TanStack Start version in integration tests Jun 11, 2025
Comment on lines +11 to +20
"@tanstack/react-router": "1.120.17",
"@tanstack/router-generator": "1.120.17",
"@tanstack/react-router-devtools": "1.120.17",
"@tanstack/react-start": "1.120.17",
"@tanstack/react-start-config": "1.120.17",
"@tanstack/router-plugin": "1.120.17",
"@tanstack/react-start-client": "1.120.17",
"@tanstack/react-start-plugin": "1.120.17",
"@tanstack/react-start-server": "1.120.17",
"@tanstack/start-server-core": "1.120.17",
Copy link
Member Author

@wobsoriano wobsoriano Jun 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See TanStack/router#4380 (comment)

This will be updated in #5973

@wobsoriano wobsoriano merged commit b23d4ae into main Jun 11, 2025
41 checks passed
@wobsoriano wobsoriano deleted the rob/fix-ts-start-tests branch June 11, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants