Skip to content

chore(clerk-js): Refactor CheckoutForm and AddPaymentSource #5980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 38 commits into
base: main
Choose a base branch
from

Conversation

panteliselef
Copy link
Member

@panteliselef panteliselef commented May 22, 2025

Description

This PR removes a lot of the drop drilling that was happening between CheckoutForm and AddPaymentSource.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

# Conflicts:
#	packages/clerk-js/src/ui/components/Checkout/CheckoutPage.tsx
#	packages/clerk-js/src/ui/components/Checkout/useCheckout.ts
…-commerce' into elef/com-798-use-swr-for-queries-commerce
# Conflicts:
#	packages/clerk-js/src/ui/components/PaymentSources/PaymentSources.tsx
…factor-checkout-page

# Conflicts:
#	packages/clerk-js/src/ui/components/Checkout/CheckoutComplete.tsx
@panteliselef panteliselef self-assigned this May 22, 2025
Copy link

changeset-bot bot commented May 22, 2025

🦋 Changeset detected

Latest commit: 0eee3ed

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clerk/testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented May 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2025 5:36pm

Base automatically changed from elef/refactor-checkout-page to main May 28, 2025 01:19
# Conflicts:
#	packages/clerk-js/src/ui/components/Checkout/CheckoutComplete.tsx
#	packages/clerk-js/src/ui/components/Checkout/CheckoutForm.tsx
#	packages/clerk-js/src/ui/components/Checkout/CheckoutPage.tsx
#	packages/clerk-js/src/ui/components/Checkout/parts.tsx
#	packages/clerk-js/src/ui/components/PaymentSources/AddPaymentSource.tsx
#	packages/clerk-js/src/ui/components/PaymentSources/PaymentSources.tsx
@panteliselef panteliselef marked this pull request as ready for review May 28, 2025 17:37
@panteliselef panteliselef reopened this May 28, 2025
@panteliselef panteliselef requested a review from a team May 28, 2025 17:37
Copy link

pkg-pr-new bot commented May 28, 2025

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@5980

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@5980

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@5980

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@5980

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@5980

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@5980

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@5980

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@5980

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@5980

@clerk/express

npm i https://pkg.pr.new/@clerk/express@5980

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@5980

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@5980

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@5980

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@5980

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@5980

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@5980

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@5980

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@5980

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@5980

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@5980

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@5980

@clerk/types

npm i https://pkg.pr.new/@clerk/types@5980

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@5980

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@5980

commit: 0eee3ed

@panteliselef panteliselef requested a review from aeliox May 28, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants