chore(clerk-js,localizations): align en-US strings for danger zone with other translations #5800

joschi · 2025-05-02T13:19:02Z

Description

The action description for organizationProfile.profilePage.dangerSection.deleteOrganization, organizationProfile.profilePage.dangerSection.leaveOrganization, and userProfile.deletePage wasn't aligned with any other translation which put the organization name or the phrase to type into the confirmation field in double quotes.

Examples from en-GB and the existing en-US localizations:

javascript/packages/localizations/src/en-GB.ts

Lines 215 to 229 in 62692cb

    
           deleteOrganization: { 
        
             actionDescription: 'Type "{{organizationName}}" below to continue.', 
        
             messageLine1: 'Are you sure you want to delete this organisation?', 
        
             messageLine2: 'This action is permanent and irreversible.', 
        
             successMessage: 'You have deleted the organisation.', 
        
             title: 'Delete organisation', 
        
           }, 
        
           leaveOrganization: { 
        
             actionDescription: 'Type "{{organizationName}}" below to continue.', 
        
             messageLine1: 
        
               'Are you sure you want to leave this organisation? You will lose access to this organisation and its applications.', 
        
             messageLine2: 'This action is permanent and irreversible.', 
        
             successMessage: 'You have left the organisation.', 
        
             title: 'Leave organisation', 
        
           },

javascript/packages/localizations/src/en-GB.ts

Lines 757 to 763 in 62692cb

    
           deletePage: { 
        
             actionDescription: 'Type "Delete account" below to continue.', 
        
             confirm: 'Delete account', 
        
             messageLine1: 'Are you sure you want to delete your account?', 
        
             messageLine2: 'This action is permanent and irreversible.', 
        
             title: 'Delete account', 
        
           },

javascript/packages/localizations/src/en-US.ts

Lines 209 to 223 in 62692cb

    
           deleteOrganization: { 
        
             actionDescription: 'Type "{{organizationName}}" below to continue.', 
        
             messageLine1: 'Are you sure you want to delete this organization?', 
        
             messageLine2: 'This action is permanent and irreversible.', 
        
             successMessage: 'You have deleted the organization.', 
        
             title: 'Delete organization', 
        
           }, 
        
           leaveOrganization: { 
        
             actionDescription: 'Type "{{organizationName}}" below to continue.', 
        
             messageLine1: 
        
               'Are you sure you want to leave this organization? You will lose access to this organization and its applications.', 
        
             messageLine2: 'This action is permanent and irreversible.', 
        
             successMessage: 'You have left the organization.', 
        
             title: 'Leave organization', 
        
           },

javascript/packages/localizations/src/en-US.ts

Lines 753 to 759 in 62692cb

    
           deletePage: { 
        
             actionDescription: 'Type "Delete account" below to continue.', 
        
             confirm: 'Delete account', 
        
             messageLine1: 'Are you sure you want to delete your account?', 
        
             messageLine2: 'This action is permanent and irreversible.', 
        
             title: 'Delete account', 
        
           },

Checklist

pnpm test runs as expected.
pnpm build runs as expected.

Type of change

Summary by CodeRabbit

Style
- Updated user instructions to display certain phrases and organization names within double quotes when confirming account or organization deletion actions.

changeset-bot · 2025-05-02T13:19:06Z

⚠️ No Changeset found

Latest commit: 6de07af

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2025-05-02T13:19:07Z

@joschi is attempting to deploy a commit to the Clerk Production Team on Vercel.

A member of the Team first needs to authorize it.

clerk-cookie · 2025-06-29T00:01:44Z

Hello 👋

We currently close PRs after 60 days of inactivity. It's been 50 days since the last update here. If we missed this PR, please reply here. Otherwise, we'll close this PR in 10 days.

Thanks for being a part of the Clerk community! 🙏

coderabbitai · 2025-06-29T00:03:50Z

📝 Walkthrough

Walkthrough

The update modifies string values within the enUS_v4 localization object, specifically adjusting the actionDescription fields. The changes add explicit double quotes around the phrases "Delete account" and the organization name placeholder {{organizationName}} in user instructions related to account deletion and organization management. No other code, logic, or exported entities are affected; only the content of the localized strings is altered.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0f5145e and 7518f3a.

📒 Files selected for processing (1)

packages/localizations/src/utils/enUS_v4.ts (2 hunks)

🧰 Additional context used

📓 Path-based instructions (4)

`**/*.{js,ts,tsx,jsx}`: All code must pass ESLint checks with the project's configuration. Use Prettier for consistent code formatting.

**/*.{js,ts,tsx,jsx}: All code must pass ESLint checks with the project's configuration.
Use Prettier for consistent code formatting.

📄 Source: CodeRabbit Inference Engine (.cursor/rules/development.mdc)

List of files the instruction was applied to:

packages/localizations/src/utils/enUS_v4.ts

`**/*.{ts,tsx}`: Maintain comprehensive JSDoc comments for public APIs.

**/*.{ts,tsx}: Maintain comprehensive JSDoc comments for public APIs.

📄 Source: CodeRabbit Inference Engine (.cursor/rules/development.mdc)

List of files the instruction was applied to:

packages/localizations/src/utils/enUS_v4.ts

`packages/**`: All publishable packages under the @clerk namespace must be located in the packages/ directory.

packages/**: All publishable packages under the @clerk namespace must be located in the packages/ directory.

📄 Source: CodeRabbit Inference Engine (.cursor/rules/global.mdc)

List of files the instruction was applied to:

packages/localizations/src/utils/enUS_v4.ts

`**/*.ts`: Always define explicit return types for functions, especially public ...

**/*.ts: Always define explicit return types for functions, especially public APIs.
Use proper type annotations for variables and parameters where inference isn't clear.
Avoid any type; prefer unknown when type is uncertain, then narrow with type guards.
Use interface for object shapes that might be extended; use type for unions, primitives, and computed types.
Prefer readonly properties for immutable data structures.
Use private for internal implementation details, protected for inheritance, and public explicitly for clarity in public APIs.
Prefer composition and interfaces over deep inheritance chains; use mixins for shared behavior.
Use ES6 imports/exports consistently; avoid barrel files (index.ts re-exports) to prevent circular dependencies.
Use type-only imports (import type { ... }) where possible.
Use as const for literal types and the satisfies operator for type checking without widening.
Enable --incremental and --tsBuildInfoFile for faster builds.
Use ESLint with @typescript-eslint/recommended rules and Prettier for formatting.
Use lint-staged and Husky for pre-commit checks.
Use type-coverage to measure type safety.

📄 Source: CodeRabbit Inference Engine (.cursor/rules/typescript.mdc)

List of files the instruction was applied to:

packages/localizations/src/utils/enUS_v4.ts

🧠 Learnings (2)

📓 Common learnings

Learnt from: dstaley
PR: clerk/javascript#6116
File: .changeset/tangy-garlics-say.md:1-2
Timestamp: 2025-06-13T16:09:53.061Z
Learning: In the Clerk JavaScript repository, contributors create intentionally empty changeset files (containing only the YAML delimiters) when a PR touches only non-published parts of the codebase (e.g., sandbox assets). This signals that no package release is required, so such changesets should not be flagged as missing content.

packages/localizations/src/utils/enUS_v4.ts (1)

Learnt from: jacekradko
PR: clerk/javascript#5905
File: .changeset/six-ears-wash.md:1-3
Timestamp: 2025-06-26T03:27:05.511Z
Learning: In the Clerk JavaScript repository, changeset headers support single quotes syntax (e.g., '@clerk/backend': minor) and work fine with their current changesets integration, so there's no need to change them to double quotes.

🔇 Additional comments (3)

packages/localizations/src/utils/enUS_v4.ts (3)

517-523: Consistency fix looks good

Wrapping the confirmation phrase in double quotes improves clarity and aligns this locale with others. No further action required.

561-568: Placeholder usage remains correct after quoting

The placeholder {{organizationName}} is now enclosed in double quotes; runtime interpolation will still work and UX benefits from visual emphasis.

569-575: LGTM – matches en-GB translation

No functional impact; translation consistency improved.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

joschi · 2025-06-29T19:00:27Z

If we missed this PR, please reply here.

Reply. 🤷

…th other translations The action description for `organizationProfile.profilePage.dangerSection.deleteOrganization`, `organizationProfile.profilePage.dangerSection.leaveOrganization`, and `userProfile.deletePage` wasn't aligned with any other translation which put the organization name or the phrase to type into the confirmation field in double quotes. https://github.com/clerk/javascript/blob/62692cb5af643ab1369421a2b961f32c701a70e3/packages/localizations/src/en-GB.ts#L215-L229 https://github.com/clerk/javascript/blob/62692cb5af643ab1369421a2b961f32c701a70e3/packages/localizations/src/en-GB.ts#L757-L763 https://github.com/clerk/javascript/blob/62692cb5af643ab1369421a2b961f32c701a70e3/packages/localizations/src/en-US.ts#L209-L223 https://github.com/clerk/javascript/blob/62692cb5af643ab1369421a2b961f32c701a70e3/packages/localizations/src/en-US.ts#L753-L759

clerk-cookie added the localizations label May 2, 2025

joschi force-pushed the patch-1 branch from a483da5 to 7518f3a Compare May 9, 2025 09:25

clerk-cookie added Stale and removed Stale labels Jun 29, 2025

joschi force-pushed the patch-1 branch from 7518f3a to 6de07af Compare June 29, 2025 19:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore(clerk-js,localizations): align en-US strings for danger zone with other translations #5800

chore(clerk-js,localizations): align en-US strings for danger zone with other translations #5800

joschi commented May 2, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

changeset-bot bot commented May 2, 2025 •

edited

Loading

Uh oh!

vercel bot commented May 2, 2025

Uh oh!

clerk-cookie commented Jun 29, 2025

Uh oh!

coderabbitai bot commented Jun 29, 2025

Walkthrough

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

joschi commented Jun 29, 2025

Uh oh!

Uh oh!

	deleteOrganization: {
	actionDescription: 'Type "{{organizationName}}" below to continue.',
	messageLine1: 'Are you sure you want to delete this organisation?',
	messageLine2: 'This action is permanent and irreversible.',
	successMessage: 'You have deleted the organisation.',
	title: 'Delete organisation',
	},
	leaveOrganization: {
	actionDescription: 'Type "{{organizationName}}" below to continue.',
	messageLine1:
	'Are you sure you want to leave this organisation? You will lose access to this organisation and its applications.',
	messageLine2: 'This action is permanent and irreversible.',
	successMessage: 'You have left the organisation.',
	title: 'Leave organisation',
	},

	deletePage: {
	actionDescription: 'Type "Delete account" below to continue.',
	confirm: 'Delete account',
	messageLine1: 'Are you sure you want to delete your account?',
	messageLine2: 'This action is permanent and irreversible.',
	title: 'Delete account',
	},

chore(clerk-js,localizations): align en-US strings for danger zone with other translations #5800

Are you sure you want to change the base?

chore(clerk-js,localizations): align en-US strings for danger zone with other translations #5800

Conversation

joschi commented May 2, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Type of change

Summary by CodeRabbit

Uh oh!

changeset-bot bot commented May 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

vercel bot commented May 2, 2025

Uh oh!

clerk-cookie commented Jun 29, 2025

Uh oh!

coderabbitai bot commented Jun 29, 2025

Walkthrough

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

joschi commented Jun 29, 2025

Uh oh!

Uh oh!

joschi commented May 2, 2025 •

edited by coderabbitai bot

Loading

changeset-bot bot commented May 2, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)