fix(clerk-js): Lazily load BillingPage in UserProfile #5409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fe22bda The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
brkalow
approved these changes
Mar 21, 2025
brkalow
reviewed
Mar 21, 2025
brkalow
reviewed
Mar 21, 2025
iagodahlem
approved these changes
Mar 21, 2025
panteliselef
approved these changes
Mar 21, 2025
| @@ -52,7 +59,9 @@ export const UserProfileRoutes = () => { | |||
| <Route path={isBillingPageRoot ? undefined : 'billing'}> | |||
| <Switch> | |||
| <Route index> | |||
| <BillingPage /> | |||
| <Suspense fallback={''}> | |||
There was a problem hiding this comment.
We probably need a proper skeleton, but we can add it later.
| @@ -14,6 +15,12 @@ export const UserProfileRoutes = () => { | |||
| const isSecurityPageRoot = pages.routes[0].id === USER_PROFILE_NAVBAR_ROUTE_ID.SECURITY; | |||
| const isBillingPageRoot = pages.routes[0].id === USER_PROFILE_NAVBAR_ROUTE_ID.BILLING; | |||
|
|
|||
| const BillingPage = lazy(() => | |||
| import('./BillingPage').then(module => ({ | |||
There was a problem hiding this comment.
Let's track its size, and add it to bundlewatch config.
Suggested change
| import('./BillingPage').then(module => ({ | |
| import( /* webpackChunkName: "up:billing-page"*/ './BillingPage').then(module => ({ |
tmilewski
approved these changes
Mar 21, 2025
panteliselef
changed the title
# Conflicts: # packages/clerk-js/bundlewatch.config.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Lazy load BillingPage only when commerce is enabled, to avoid unnecessary loading of Stripe.
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change