Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add React Native support #5209

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

boorad
Copy link

@boorad boorad commented Feb 21, 2025

Description

WIP

This PR adds Clerk support for React Native applications.

Status: For now, it is a direct copy of @clerk/clerk-expo source code, adapted to work in non-Expo apps. If it can be made to work fully, and is desirable for Clerk, then future commits to the PR will separate out all shared code to packages/react-native-core or similar, and packages/expo & packages/react-native will only hold the different bits but have similar/identical exports. Then, docs and guides would follow before merging.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Copy link

changeset-bot bot commented Feb 21, 2025

⚠️ No Changeset found

Latest commit: f1a7c90

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Feb 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 21, 2025 2:13am

@boorad
Copy link
Author

boorad commented Feb 21, 2025

I can't seem to get past this error, and would love some Clerk 👀 to take a look.
Simulator Screenshot - iPhone 16 Pro - 2025-02-20 at 21 00 20

@boorad
Copy link
Author

boorad commented Feb 21, 2025

example app: https://github.com/boorad/rnclerk

@LekoArts
Copy link
Member

Hi!
Thanks for putting up the PR, appreciate it 😊

We've talked about the PR internally but haven't come to a decision yet what to do with it. Accepting it into this repository would mean increased long-term maintenance cost and certain expectations to shipping new features to it, too. We encourage and see that third parties create unofficial SDKs (We've also written a guide for it at https://clerk.com/docs/references/sdk/overview), and this will always be a good option.

I'll get back to you until the end of this week on next steps 👍

@boorad
Copy link
Author

boorad commented Mar 11, 2025

@LekoArts thanks for the reply. It's not ready to merge yet. I was just looking for help w/ Clerk internals and why I was seeing that error. Once that is solved, I can take all the copied code and make it shared so maintenance and upkeep is simpler. But let me know...

@LekoArts
Copy link
Member

Yes, we're happy to help to get the SDK into a functioning state 👍

Are you interested in publishing this SDK under your own name and treat it like a community SDK? Like https://github.com/DarrenBaldwin07/clerk-rs for example?

@boorad
Copy link
Author

boorad commented Mar 14, 2025

Are you interested in publishing this SDK under your own name and treat it like a community SDK

Yes, no problem. But there may be some patches to the main repo so we are not duplicating so much code.

@LekoArts
Copy link
Member

Yeah, upstream changes are fine if it makes things easier 👍 Are you on Clerk's Discord by any chance? I do wonder about the best sync communication method of helping you with the SDK.

@boorad
Copy link
Author

boorad commented Mar 25, 2025

Yeah, upstream changes are fine if it makes things easier 👍 Are you on Clerk's Discord by any chance? I do wonder about the best sync communication method of helping you with the SDK.

I am now. boorad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants