-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add React Native support #5209
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
example app: https://github.com/boorad/rnclerk |
Hi! We've talked about the PR internally but haven't come to a decision yet what to do with it. Accepting it into this repository would mean increased long-term maintenance cost and certain expectations to shipping new features to it, too. We encourage and see that third parties create unofficial SDKs (We've also written a guide for it at https://clerk.com/docs/references/sdk/overview), and this will always be a good option. I'll get back to you until the end of this week on next steps 👍 |
@LekoArts thanks for the reply. It's not ready to merge yet. I was just looking for help w/ Clerk internals and why I was seeing that error. Once that is solved, I can take all the copied code and make it shared so maintenance and upkeep is simpler. But let me know... |
Yes, we're happy to help to get the SDK into a functioning state 👍 Are you interested in publishing this SDK under your own name and treat it like a community SDK? Like https://github.com/DarrenBaldwin07/clerk-rs for example? |
Yes, no problem. But there may be some patches to the main repo so we are not duplicating so much code. |
Yeah, upstream changes are fine if it makes things easier 👍 Are you on Clerk's Discord by any chance? I do wonder about the best sync communication method of helping you with the SDK. |
I am now. |
Description
This PR adds Clerk support for React Native applications.
Status: For now, it is a direct copy of
@clerk/clerk-expo
source code, adapted to work in non-Expo apps. If it can be made to work fully, and is desirable for Clerk, then future commits to the PR will separate out all shared code topackages/react-native-core
or similar, andpackages/expo
&packages/react-native
will only hold the different bits but have similar/identical exports. Then, docs and guides would follow before merging.Checklist
pnpm test
runs as expected.pnpm build
runs as expected.Type of change