fix(clerk-js): Fix stale SignIn object on authenticateWithRedirect for enterprise custom flows

[LauraBeatris]

Description

Resolves ORGS-540

Currently, authenticateWithRedirect always uses the existing SignIn for saml or enterprise_sso strategy, even if the identifier gets changed by the user in a custom flow, which leads to an issue where FAPI queries the wrong enterprise connection:

CleanShot.2025-02-10.at.16.20.39.mp4

Our SignInStart component always creates a new SignIn; therefore, the flow above works smoothly:

javascript/packages/clerk-js/src/ui/components/SignIn/SignInStart.tsx

Lines 299 to 312 in e182055

	const res = await safePasswordSignInForEnterpriseSSOInstance(signIn.create(buildSignInParams(fields)), fields);
	switch (res.status) {
	case 'needs_identifier':
	// Check if we need to initiate an enterprise sso flow
	if (res.supportedFirstFactors?.some(ff => ff.strategy === 'saml' || ff.strategy === 'enterprise_sso')) {
	await authenticateWithEnterpriseSSO();
	}
	break;
	case 'needs_first_factor':
	if (res.supportedFirstFactors?.every(ff => ff.strategy === 'enterprise_sso')) {
	await authenticateWithEnterpriseSSO();
	break;
	}

With fix

This PR introduces a new continueSignIn option for signIn.authenticateWithRedirect, which defaults to false, therefore it'll create a new SignIn object on every call.

Within SignInStart, we pass continueSignIn as false in order to reuse the current SignIn created, in order to avoid calling signIn.create twice.

CleanShot.2025-02-10.at.16.21.32.mp4

Checklist

• pnpm test runs as expected.
• pnpm build runs as expected.
• (If applicable) JSDoc comments have been added or updated for any package exports
• (If applicable) Documentation has been updated

Type of change

• 🐛 Bug fix
• 🌟 New feature
• 🔨 Breaking change
• 📖 Refactoring / dependency upgrade / documentation
• other:

[changeset-bot]

🦋 Changeset detected

Latest commit: 73eb240

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@clerk/clerk-js	Patch
@clerk/chrome-extension	Patch
@clerk/clerk-expo	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
clerk-js-sandbox	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 10, 2025 9:24pm