feat(backend): cache by optional kid param in loadClerkJWKFromLocal #5035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7bd970b The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Can someone check this out...? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates
loadClerkJWKFromLocalto accept an optional second parameterkidthat allows overriding the defaultlocalcache key.Original behaviour preserved using default value for new
kidfield.I also updated the
loads the local key in PEM formattest to make use of the cache key override, because the original test would always be successful since the firstloads the local keytest would create a cache entry, so the logic to parse the key in the second test was skipped.A secondary note, while adding this and updating tests, I noticed the
throws an error if no key has been providedtest will only ever succeed if there is nothing in the cache for the cache key. I haven't changed this test as part of this PR but thought it was worth raising that the test does not work when there is a cached value, allowing passingundefinedto be successful. (I actually make use of this in a test to demonstrateloadClerkJWKFromLocalusing a custom cache key).Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change