chore(backend): Expose AuthObject type
#3844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…AuthObject, SignedOutAuthObject, and AuthObject type definitions in favour of exporting from @clerk/types
…ject, SignedOutAuthObject, and AuthObject type definitions to token.ts * Mark AuthObjectDebugData, AuthObjectDebug, SignedInAuthObject, SignedOutAuthObject as internal types
…ve export from internal.ts of removed types
🦋 Changeset detectedLatest commit: 91995d6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
LekoArts
changed the title
AuthObject type
nikosdouvlis
approved these changes
Aug 6, 2024
dimkl
approved these changes
Aug 6, 2024
dimkl
reviewed
Aug 6, 2024
| SignedOutAuthObject, | ||
| AuthObject, | ||
| } from './tokens/authObjects'; | ||
| export type { SignedInAuthObjectOptions, SignedInAuthObject, SignedOutAuthObject } from './tokens/authObjects'; |
There was a problem hiding this comment.
🔧 This change will break existing application importing from /internal. Even though they should not use it, should we keep it and add a deprecation warning to remove it later?
cc: @nikosdouvlis
LekoArts
deleted the
kenton/sdk-1894-export-authobject-as-requested-by-client-in-clerktypes
branch
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR moves the AuthObjectDebugData, AuthObjectDebug, SignedInAuthObject, SignedOutAuthObject, and AuthObject type definitions in favour of exporting from @clerk/types. This is to enable clients to easily access this object type across our JavaScript SDKs.
https://linear.app/clerk/issue/SDK-1894/export-authobject-as-requested-by-client-in-clerktypes-package
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change