Skip to content

Conversation

@wobsoriano
Copy link
Member

@wobsoriano wobsoriano commented Jul 30, 2024

Description

This PR adds notice of plan to EOL Gatsby SDK

Fixes ECO-86 and ECO-92

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot
Copy link

changeset-bot bot commented Jul 30, 2024

🦋 Changeset detected

Latest commit: 5d83cc6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
gatsby-plugin-clerk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

"baseBranch": "origin/main",
"updateInternalDependencies": "patch",
"ignore": ["gatsby-plugin-clerk"],
"ignore": [],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temporarily removing the gatsby SDK to ignored list so we can publish the notice to NPM

Copy link
Member

@nikosdouvlis nikosdouvlis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻
Let's make sure that this package gets released under the 4 version tag before release

@wobsoriano
Copy link
Member Author

wobsoriano commented Aug 1, 2024

@nikosdouvlis thanks for reviewing!

That just means updating the version in the package.json file back to 4.4.7 (the last main version), right? Or are there any other steps required?

Also since 4.x.x is in Core 1, would doing this release a 4.x.x in Core 2?

@wobsoriano wobsoriano changed the title chore(gatsby): Add transition period notice chore(gatsby-plugin-clerk): Add transition period notice Aug 1, 2024
@wobsoriano wobsoriano force-pushed the rob/eco-86-add-notice-of-eol-on-repo-readme branch from a7d7462 to 5d83cc6 Compare August 1, 2024 15:00
@wobsoriano wobsoriano marked this pull request as ready for review August 1, 2024 18:15
@wobsoriano wobsoriano merged commit 35fb0c7 into main Aug 1, 2024
@wobsoriano wobsoriano deleted the rob/eco-86-add-notice-of-eol-on-repo-readme branch August 1, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants