Skip to content

Conversation

@anagstef
Copy link
Member

@anagstef anagstef commented Apr 17, 2024

Description

Center the Turnstile widget on SSO callback

Screenshot 2024-04-17 at 10 56 51

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot
Copy link

changeset-bot bot commented Apr 17, 2024

🦋 Changeset detected

Latest commit: f140193

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@nikosdouvlis nikosdouvlis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, why do we use turnstile in this part of the flow?

@anagstef
Copy link
Member Author

@nikosdouvlis This is the transfer flow. It's when the signUp.create() is called, which renders the widget.

@anagstef anagstef enabled auto-merge (squash) April 17, 2024 08:25
@anagstef anagstef merged commit beac05f into main Apr 17, 2024
@anagstef anagstef deleted the stefanos/core-2089-center-widget branch April 17, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants