Skip to content

Conversation

@ezkomoly
Copy link
Contributor

Description

Added hungarian language

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other: Localization

@changeset-bot
Copy link

changeset-bot bot commented Apr 15, 2024

🦋 Changeset detected

Latest commit: 4662207

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@clerk/localizations Minor
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ezkomoly
Copy link
Contributor Author

I forgot to add the Changeset. Not sure, if I could do it at this point, or should I open a new PR ?

Copy link
Contributor

@dimkl dimkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @ezkomoly,
thank you for the contribution!! :)
It seems that a few things are missing for this PR to allow us to merge it:

  • export the hu-HU.ts from the localization package (need to export it from the index.ts)
  • add a changelog entry for this (check the changeset-bot comment of this PR)

@dimkl
Copy link
Contributor

dimkl commented Apr 15, 2024

@ezkomoly ignore it this time. We will add the changeset. :)

@ezkomoly
Copy link
Contributor Author

Hello @ezkomoly, thank you for the contribution!! :) It seems that a few things are missing for this PR to allow us to merge it:

  • export the hu-HU.ts from the localization package (need to export it from the index.ts)
  • add a changelog entry for this (check the changeset-bot comment of this PR)

Thanks for adding the changeset!
I exported huHU from the index.ts.

Copy link
Member

@tmilewski tmilewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@nikosdouvlis nikosdouvlis merged commit 1078e8c into clerk:main Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants