fix(clerk-js,clerk-react): Make UI-triggered redirects default to hash-based routing #3061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h-based routing If a routing strategy is not provided, default to hash routing. All routing strategies know how to convert a hash-based url to their own format Example: navigating from a hash-based to a path-based component, the path-based component can parse and fix the URL automatically /#/sso-callback?code=123 -> /sso-callback?code=123
🦋 Changeset detectedLatest commit: 9efba77 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
nikosdouvlis
force-pushed
the
nikos/sdk-1540-default-path-routing-by-default-in-clerk-js
branch
from
738dee4 to
3861995
Compare
panteliselef
approved these changes
Apr 1, 2024
desiprisg
approved these changes
Apr 5, 2024
Co-authored-by: panteliselef <panteliselef@outlook.com>
nikosdouvlis
deleted the
nikos/sdk-1540-default-path-routing-by-default-in-clerk-js
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a routing strategy is not provided, default to hash routing. All routing strategies know how to convert a hash-based url to their own format Example: navigating from a hash-based to a path-based component, the path-based component can parse and fix the URL automatically /#/sso-callback?code=123 -> /sso-callback?code=123
Description
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change