Skip to content

Conversation

@LekoArts
Copy link
Contributor

@LekoArts LekoArts commented Nov 29, 2023

Description

While reading #2154 I noticed that telemetry was missing from the files array in package.json. This is needed for the "Expo folder workaround" with the subpaths.

Currently the folder is missing from the published source: https://unpkg.com/browse/@clerk/shared@2.0.0-alpha-v5.3/

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore

@changeset-bot
Copy link

changeset-bot bot commented Nov 29, 2023

🦋 Changeset detected

Latest commit: b743cfb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@clerk/shared Patch
@clerk/backend Patch
@clerk/clerk-js Patch
@clerk/clerk-expo Patch
@clerk/fastify Patch
@clerk/nextjs Patch
@clerk/clerk-react Patch
@clerk/remix Patch
@clerk/clerk-sdk-node Patch
gatsby-plugin-clerk Patch
@clerk/chrome-extension Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@LekoArts LekoArts changed the title fix(shared): Add missing files entry in package.json fix(shared): Add missing entry in files of package.json Nov 29, 2023
@LekoArts LekoArts requested a review from brkalow November 29, 2023 10:28
@nikosdouvlis nikosdouvlis added this pull request to the merge queue Nov 29, 2023
Merged via the queue into main with commit c776f86 Nov 29, 2023
@nikosdouvlis nikosdouvlis deleted the fix/add-missing-files-entry branch November 29, 2023 10:41
@dimkl
Copy link
Contributor

dimkl commented Nov 29, 2023

@anagstef has created a workflow to notify PR authors to include changes in clerk-js/ui to the clerk-js/ui.retheme and to the other *.retheme.ts files. Should we re-use that reminder for the shared package and the subpath exports to inform about adding the changes to package.json?
cc: @LekoArts , @nikosdouvlis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants