Skip to content

Conversation

@panteliselef
Copy link
Member

Description

This PR replaces the deprecated usage of organizationList from useOrganizationList with userMemberships that is returned from the same hook.

This PR also unblocks #2102

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore

@panteliselef panteliselef self-assigned this Nov 13, 2023
@panteliselef panteliselef requested a review from a team as a code owner November 13, 2023 10:58
@changeset-bot
Copy link

changeset-bot bot commented Nov 13, 2023

🦋 Changeset detected

Latest commit: 5c4242d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

/>
</PreviewButton>
))}
{(hasNextPage || isLoading) && <InfiniteListSpinner ref={ref} />}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ are we sure about showing the InfiniteListSpinner when hasNextPage is true?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we've been following this pattern for a while, i believe this just improves the UI in general by minimizing layout shifts when the loading get triggered.

F.e.: You scroll, u are about to reach the bottom and u see a spinner, the spinner triggers the request (to fetch the next page) and u continue to see the spinner until loading is completed, now the spinner is pushed further now and no requests will fire until it is in the users viewport again.

@dimkl dimkl mentioned this pull request Nov 13, 2023
24 tasks
@panteliselef panteliselef added this pull request to the merge queue Nov 13, 2023
Merged via the queue into main with commit 2705246 Nov 13, 2023
@panteliselef panteliselef deleted the elef/sdk-939-switcher-userMemberships branch November 13, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants