Skip to content

fix(backend): strip experimental__has from serializable auth object #2101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 9, 2023
Merged

fix(backend): strip experimental__has from serializable auth object #2101

merged 3 commits into from
Nov 9, 2023

Conversation

@brkalow
Copy link
Member

@brkalow brkalow commented Nov 9, 2023

Description

Strip experimental__has from the auth object in makeAuthObjectSerializable(). This fixes an issue in Next.js where an error is being thrown when this function is passed to a client component as a prop.

fixes #2097

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore

@brkalow brkalow requested a review from a team as a code owner November 9, 2023 18:52
@changeset-bot
Copy link

changeset-bot bot commented Nov 9, 2023

🦋 Changeset detected

Latest commit: 755f838

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@clerk/backend Patch
@clerk/fastify Patch
gatsby-plugin-clerk Patch
@clerk/nextjs Patch
@clerk/remix Patch
@clerk/clerk-sdk-node Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brkalow brkalow requested a review from panteliselef November 9, 2023 18:55
@brkalow brkalow added this pull request to the merge queue Nov 9, 2023
Merged via the queue into main with commit a6451ae Nov 9, 2023
@brkalow brkalow deleted the brk.fix/auth-object-serializable branch November 9, 2023 19:32
@clerk-cookie clerk-cookie mentioned this pull request Nov 9, 2023
Merged
@brkalow brkalow mentioned this pull request Nov 9, 2023
Merged
brkalow added a commit that referenced this pull request Nov 9, 2023
@brkalow
fix(backend): strip experimental__has from serializable auth object (#…
86448c8 
…2101)

* fix(backend): Add experimental__has to properties strip out by makeAuthObjectSerializable

* chore(backend): Add test case for makeAuthObjectSerializable

* chore(repo): Add changeset

(cherry picked from commit a6451ae)
github-merge-queue bot pushed a commit that referenced this pull request Nov 9, 2023
@brkalow
fix(backend): strip experimental__has from serializable auth object (#…
1df2ffe 
…2101) (#2103)

* fix(backend): Add experimental__has to properties strip out by makeAuthObjectSerializable

* chore(backend): Add test case for makeAuthObjectSerializable

* chore(repo): Add changeset

(cherry picked from commit a6451ae)
@LekoArts LekoArts mentioned this pull request Mar 13, 2024
Merged
@LekoArts LekoArts mentioned this pull request Aug 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tmilewski tmilewski tmilewski approved these changes

@panteliselef panteliselef panteliselef approved these changes

Assignees

@brkalow brkalow

Labels

backend

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

NextJS (App Router) Error with > v4.26.2

5 participants

@brkalow @tmilewski @panteliselef @clerk-cookie