Repository navigation
feat(expo-biometrics): migrate to Expo Modules API 2.0 - #10301
Draft
wobsoriano wants to merge 2 commits into
Draft
wobsoriano wants to merge 2 commits into
wobsoriano wants to merge 2 commits into
Conversation
Moves ClerkExpoBiometrics to @ExpoModule/@JS/@record on iOS and io.github.expo.modules.v2 on Android. Blocking Keychain, Secure Enclave, Keystore and file work stays off the JS thread (.concurrent on iOS, Dispatchers.IO on Android), and store operations stay on the main actor on iOS. Android builds with expo-module-gradle-plugin and v2 enabled, so the module leaves android.modules in expo-module.config.json. The native contract test now reads @js functions as well as the DSL.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: b1e06e5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/electron
@clerk/electron-passkeys
@clerk/eslint-plugin
@clerk/expo
@clerk/expo-biometrics
@clerk/expo-google-signin
@clerk/expo-native-components
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/mosaic
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Exploration only. I want to see what Expo Modules API 2.0 (beta in SDK 58) looks like in our code, and what it is still missing.
This PR migrates
@clerk/expo-biometricson iOS and Android. Every member moved, with no 1.0 DSL left. The function names, arguments, record fields and error codes JS sees are unchanged. Error messages lose the 1.0 "Calling the 'x' function has failed" prefix, andPromise<void>on Android resolves toundefinedinstead ofnull.What is missing or blocking:
@ExpoView/@ViewProps, so theexpo-native-componentsviews (AuthView, UserProfileView, UserButton) stay on 1.0.Moduleis a different base class, so an Android module moves all at once. iOS allows mixing.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change