Upgrade to v5 #1
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
JacobMGEvans
suggested changes
Jan 19, 2024
Comment on lines
4
to
9
| export default clerkMiddleware(async (auth, req) => { | ||
| if (req.nextUrl.pathname === "/dashboard" && !auth().userId) { | ||
| auth().protect(); | ||
|
|
||
| return NextResponse.next(); | ||
| } |
There was a problem hiding this comment.
Lets encourage the use of the pattern matcher helper.
Suggested change
| export default clerkMiddleware(async (auth, req) => { | |
| if (req.nextUrl.pathname === "/dashboard" && !auth().userId) { | |
| auth().protect(); | |
| return NextResponse.next(); | |
| } | |
| const isProtectedRoute = createRouteMatcher(['dashboard/(.*)']); | |
| export default clerkMiddleware(async (auth, req) => { | |
| if (isProtectedRoute(req) && !auth().userId) { | |
| auth().protect(); | |
| return NextResponse.next(); | |
| } |
Contributor
Author
There was a problem hiding this comment.
Great catch, oddly I believe in other places I was doing just that so idk why i did this lol
… to middleware to protect the dashboard
JacobMGEvans
approved these changes
Jan 19, 2024
JacobMGEvans
left a comment
JacobMGEvans
left a comment
There was a problem hiding this comment.
Tentative to the question but non-blocking
|
|
||
| export default clerkMiddleware(async (auth, req) => { | ||
| if (isProtectedDashboardRoute(req) && !auth().userId) { | ||
| auth().protect(); |
There was a problem hiding this comment.
Does this need to be:
Suggested change
| auth().protect(); | |
| return auth().protect(); |
There was a problem hiding this comment.
Did we find out if its necessary to return the protect function?
|
can't see either demo site for pages or app implentations |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
authMiddlewarewithclerkMiddlewareand protected the/dashboardrouteauthto the new server import from@clerk/nextjs/server