Skip to content

feat: adds telemetry page #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jan 9, 2024
Merged

feat: adds telemetry page #496

merged 12 commits into from
Jan 9, 2024

Conversation

@brkalow
Copy link
Member

@brkalow brkalow commented Nov 16, 2023 •
edited
Loading

fixes SDK-981

@github-actions
Copy link
Contributor

github-actions bot commented Nov 16, 2023 •
edited
Loading

Hey @LekoArts, your docs preview is available.

Status Preview Updated (UTC)
🍪 Updated Visit preview Jan 09, 2024 02:39 PM

@brkalow brkalow marked this pull request as ready for review November 16, 2023 23:37
@brkalow brkalow mentioned this pull request Nov 17, 2023
Merged
24 tasks
alexisintech
alexisintech requested changes Nov 20, 2023
View reviewed changes
brkalow
brkalow commented Nov 20, 2023
View reviewed changes
brkalow
brkalow commented Nov 20, 2023
View reviewed changes
brkalow and others added 3 commits November 20, 2023 11:57
@brkalow @alexisintech
Apply suggestions from code review
f425d00 
Co-authored-by: Alexis Aguilar <98043211+alexisintech@users.noreply.github.com>
@brkalow
clarify wording
2d75c7d
@alexisintech
update the opt out section's structure and utilize codeblocktabs for …
0cae3d9 
…examples
@alexisintech alexisintech force-pushed the brk.feat/telemetry-doc branch from 086088d to 0cae3d9 Compare November 21, 2023 20:41
brkalow
brkalow commented Nov 21, 2023
View reviewed changes
@brkalow brkalow requested a review from alexisintech November 22, 2023 18:31
@alexisintech
Copy link
Member

Where can this be placed in the navigation? Maybe under advanced-usage for now? Could you add this page to the manifest.json (but do not move its location. it's fine under /docs in order to have a flat url path of /docs/telemetry as this is what we are moving the rest of the pages towards)

@brkalow
Copy link
Member Author

brkalow commented Nov 22, 2023

@alexisintech I was considering not having it in the nav 👀. Maybe that's a bad idea though. More likely this is something that would be linked to in our footer, or somewhere else more global.

@nearestnabors nearestnabors self-requested a review November 27, 2023 14:15
@nearestnabors
Copy link
Contributor

One thought is to make a "Privacy" nav item under "Security" and place this there alongside any other privacy-related content and assurances we might provide (like recommendations around user impersonation). Seems like something you'd expect to find in an auth provider's docs! Short of that, agree with @brkalow that the footer might make sense.

LekoArts
LekoArts reviewed Nov 28, 2023
View reviewed changes
LekoArts
LekoArts reviewed Nov 28, 2023
View reviewed changes
nearestnabors
nearestnabors suggested changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@nearestnabors nearestnabors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a structural perspective, I would rename the "Security" section to "Security and Privacy" and add this there. What do you think, @alexisintech ?

nearestnabors
nearestnabors approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@nearestnabors nearestnabors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Purrrrfect!

@alexisintech
Copy link
Member

holding off on merging until v5 is released

@nearestnabors
Copy link
Contributor

Why we waiting till v5? Let's give it a tag and put it into draft till then

@nearestnabors nearestnabors marked this pull request as draft December 13, 2023 12:29
@LekoArts LekoArts changed the base branch from main to release/v5 January 9, 2024 14:39
@LekoArts LekoArts marked this pull request as ready for review January 9, 2024 14:40
@LekoArts LekoArts merged commit ded4328 into release/v5 Jan 9, 2024
@LekoArts LekoArts deleted the brk.feat/telemetry-doc branch January 9, 2024 14:42
alexisintech added a commit that referenced this pull request Jan 11, 2024
@brkalow @alexisintech
@panteliselef @LekoArts
feat: adds telemetry page (#496)
a10e333 
Co-authored-by: Alexis Aguilar <98043211+alexisintech@users.noreply.github.com>
Co-authored-by: panteliselef <panteliselef@outlook.com>
Co-authored-by: Lennart <lekoarts@gmail.com>
alexisintech added a commit that referenced this pull request Feb 29, 2024
@brkalow @alexisintech
@panteliselef @LekoArts
feat: adds telemetry page (#496)
e5061ed 
Co-authored-by: Alexis Aguilar <98043211+alexisintech@users.noreply.github.com>
Co-authored-by: panteliselef <panteliselef@outlook.com>
Co-authored-by: Lennart <lekoarts@gmail.com>
alexisintech added a commit that referenced this pull request Mar 5, 2024
@brkalow @alexisintech
@panteliselef @LekoArts
feat: adds telemetry page (#496)
440eaf1 
Co-authored-by: Alexis Aguilar <98043211+alexisintech@users.noreply.github.com>
Co-authored-by: panteliselef <panteliselef@outlook.com>
Co-authored-by: Lennart <lekoarts@gmail.com>
alexisintech added a commit that referenced this pull request Mar 7, 2024
@brkalow @alexisintech
@panteliselef @LekoArts
feat: adds telemetry page (#496)
9a9d8f8 
Co-authored-by: Alexis Aguilar <98043211+alexisintech@users.noreply.github.com>
Co-authored-by: panteliselef <panteliselef@outlook.com>
Co-authored-by: Lennart <lekoarts@gmail.com>
alexisintech added a commit that referenced this pull request Mar 11, 2024
@brkalow @alexisintech
@panteliselef @LekoArts
feat: adds telemetry page (#496)
513b5b1 
Co-authored-by: Alexis Aguilar <98043211+alexisintech@users.noreply.github.com>
Co-authored-by: panteliselef <panteliselef@outlook.com>
Co-authored-by: Lennart <lekoarts@gmail.com>
alexisintech added a commit that referenced this pull request Mar 12, 2024
@brkalow @alexisintech
@panteliselef @LekoArts
feat: adds telemetry page (#496)
7c19bbc 
Co-authored-by: Alexis Aguilar <98043211+alexisintech@users.noreply.github.com>
Co-authored-by: panteliselef <panteliselef@outlook.com>
Co-authored-by: Lennart <lekoarts@gmail.com>
alexisintech added a commit that referenced this pull request Mar 12, 2024
@brkalow @alexisintech
@panteliselef @LekoArts
feat: adds telemetry page (#496)
f658243 
Co-authored-by: Alexis Aguilar <98043211+alexisintech@users.noreply.github.com>
Co-authored-by: panteliselef <panteliselef@outlook.com>
Co-authored-by: Lennart <lekoarts@gmail.com>
alexisintech added a commit that referenced this pull request Mar 14, 2024
@brkalow @alexisintech
@panteliselef @LekoArts
feat: adds telemetry page (#496)
a4c2036 
Co-authored-by: Alexis Aguilar <98043211+alexisintech@users.noreply.github.com>
Co-authored-by: panteliselef <panteliselef@outlook.com>
Co-authored-by: Lennart <lekoarts@gmail.com>
alexisintech added a commit that referenced this pull request Mar 20, 2024
@brkalow @alexisintech
@panteliselef @LekoArts
feat: adds telemetry page (#496)
827fd20 
Co-authored-by: Alexis Aguilar <98043211+alexisintech@users.noreply.github.com>
Co-authored-by: panteliselef <panteliselef@outlook.com>
Co-authored-by: Lennart <lekoarts@gmail.com>
alexisintech added a commit that referenced this pull request Mar 20, 2024
@brkalow @alexisintech
@panteliselef @LekoArts
feat: adds telemetry page (#496)
8aee38c 
Co-authored-by: Alexis Aguilar <98043211+alexisintech@users.noreply.github.com>
Co-authored-by: panteliselef <panteliselef@outlook.com>
Co-authored-by: Lennart <lekoarts@gmail.com>
alexisintech added a commit that referenced this pull request Mar 27, 2024
@brkalow @alexisintech
@panteliselef @LekoArts
feat: adds telemetry page (#496)
42e4319 
Co-authored-by: Alexis Aguilar <98043211+alexisintech@users.noreply.github.com>
Co-authored-by: panteliselef <panteliselef@outlook.com>
Co-authored-by: Lennart <lekoarts@gmail.com>
alexisintech added a commit that referenced this pull request Mar 28, 2024
@brkalow @alexisintech
@panteliselef @LekoArts
feat: adds telemetry page (#496)
83d4828 
Co-authored-by: Alexis Aguilar <98043211+alexisintech@users.noreply.github.com>
Co-authored-by: panteliselef <panteliselef@outlook.com>
Co-authored-by: Lennart <lekoarts@gmail.com>
alexisintech added a commit that referenced this pull request Apr 2, 2024
@brkalow @alexisintech
@panteliselef @LekoArts
feat: adds telemetry page (#496)
9932cc8 
Co-authored-by: Alexis Aguilar <98043211+alexisintech@users.noreply.github.com>
Co-authored-by: panteliselef <panteliselef@outlook.com>
Co-authored-by: Lennart <lekoarts@gmail.com>
alexisintech added a commit that referenced this pull request Apr 8, 2024
@brkalow @alexisintech
@panteliselef @LekoArts
feat: adds telemetry page (#496)
d55ffd4 
Co-authored-by: Alexis Aguilar <98043211+alexisintech@users.noreply.github.com>
Co-authored-by: panteliselef <panteliselef@outlook.com>
Co-authored-by: Lennart <lekoarts@gmail.com>
alexisintech added a commit that referenced this pull request Apr 11, 2024
@brkalow @alexisintech
@panteliselef @LekoArts
feat: adds telemetry page (#496)
1037acc 
Co-authored-by: Alexis Aguilar <98043211+alexisintech@users.noreply.github.com>
Co-authored-by: panteliselef <panteliselef@outlook.com>
Co-authored-by: Lennart <lekoarts@gmail.com>
kylemac pushed a commit that referenced this pull request Apr 18, 2024
@brkalow @alexisintech
@panteliselef @LekoArts @kylemac
feat: adds telemetry page (#496)
d724241 
Co-authored-by: Alexis Aguilar <98043211+alexisintech@users.noreply.github.com>
Co-authored-by: panteliselef <panteliselef@outlook.com>
Co-authored-by: Lennart <lekoarts@gmail.com>
S3Prototype pushed a commit that referenced this pull request Apr 22, 2024
@brkalow @alexisintech
@panteliselef @LekoArts @S3Prototype
feat: adds telemetry page (#496)
e2e9970 
Co-authored-by: Alexis Aguilar <98043211+alexisintech@users.noreply.github.com>
Co-authored-by: panteliselef <panteliselef@outlook.com>
Co-authored-by: Lennart <lekoarts@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexisintech alexisintech alexisintech approved these changes

+2 more reviewers

@nearestnabors nearestnabors nearestnabors approved these changes

@LekoArts LekoArts LekoArts approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@brkalow @alexisintech @nearestnabors @LekoArts @panteliselef