Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix album artist for FLAC/OGG files (with vorbis comments) #4715

Merged
merged 3 commits into from
Jan 19, 2015

Conversation

Chocobozzz
Copy link
Contributor

Fixes #3194

@ArnaudBienner
Copy link
Member

Would be nice to also read back this in ParseOggTag.
Also, is this standard? (I don't remember if other fields we are setting in comment are standards, and if it is standard to do it this way. I'm just wondering).

Also, it might be worth to add some unit test for this (in song_test.cpp?)
Maybe it is a bit overkill. But this can also help you to test this is working well, and it's probably not long to do. As you prefer.

@Chocobozzz
Copy link
Contributor Author

Yes good idea @ArnaudBienner for the tests I'll do it when I'll have time :)

ParseOggTag already implemented the ALBUM ARTIST field (line 470).

Infortunaly it doesn't seem that album artist field is a standard, but I always saw people use "ALBUMARTIST" or "ALBUM ARTIST" field name so I think it will be portable.

@Chocobozzz
Copy link
Contributor Author

It's done :)

hatstand added a commit that referenced this pull request Jan 19, 2015
Fix album artist for FLAC/OGG files (with vorbis comments)
@hatstand hatstand merged commit 87fed5d into clementine-player:master Jan 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Album Artist cannot be edited in flac in windows
3 participants