Fix CI by using ganache from docker container

.github/workflows/onpullrequest-build-ubuntu.yml

@@ -48,33 +48,18 @@ jobs:
     - uses: actions/checkout@v2
       with:
         submodules: recursive
-    - uses: actions/setup-node@v1
-      with:
-        node-version: 10
     - name: Cache grpc
       uses: actions/cache@v2
       with:
         key: grpc-1.31.x-${{ runner.os }}
         path: depends/grpc
-    # - name: Cache ccache
-    #   uses: actions/cache@v2
-    #   with:
-    #     key: prover-tests-ccache-${{ needs.onpr-submodules.outputs.commits }}-${{ matrix.curve }}-${{ runner.os }}
-    #     path: ~/.ccache
     - name: Cache pip
       uses: actions/cache@v2
       with:
         path: |
           ~/.cache/pip
           ~/Library/Caches/pip
         key: prover-tests-pip-${{ hashFiles('**/setup.py') }}-${{ runner.os }}
-    - name: Cache npm
-      uses: actions/cache@v2
-      with:
-        path: |
-          ~/.npm
-          depends/ganache-cli/node_modules
-        key: prover-tests-npm-${{ hashFiles('**/package-lock.json') }}-${{ runner.os }}
     - name: Install dependencies
       run: |
         INSTALL_ONLY=1 scripts/install-grpc /usr v1.31.x
@@ -93,35 +78,18 @@ jobs:
     - uses: actions/checkout@v2
       with:
         submodules: recursive
-    - uses: actions/setup-node@v1
-      with:
-        node-version: 10
     - name: Cache grpc
       uses: actions/cache@v2
       with:
         key: grpc-1.31.x-${{ runner.os }}
         path: depends/grpc
-    # ccache in this job seems to make the tests crash occasionally. Disabling
-    # until the cause is understood.
-    # - name: Cache ccache
-    #   uses: actions/cache@v2
-    #   with:
-    #     key: integration-tests-ccache-${{ needs.onpr-submodules.outputs.commits }}-${{ matrix.curve }}-${{ runner.os }}
-    #     path: ~/.ccache
     - name: Cache pip
       uses: actions/cache@v2
       with:
         path: |
           ~/.cache/pip
           ~/Library/Caches/pip
         key: integration-tests-pip-${{ hashFiles('**/setup.py') }}-${{ runner.os }}
-    - name: Cache npm
-      uses: actions/cache@v2
-      with:
-        path: |
-          ~/.npm
-          depends/ganache-cli/node_modules
-        key: integration-tests-npm-${{ hashFiles('**/package-lock.json') }}-${{ runner.os }}
     - name: Install dependencies
       run: |
         INSTALL_ONLY=1 scripts/install-grpc /usr v1.31.x

.github/workflows/onpush-checks.yml

@@ -12,16 +12,6 @@ jobs:
     - uses: actions/checkout@v2
       with:
         submodules: recursive
-    - uses: actions/setup-node@v2
-      with:
-        node-version: '10'
-    - name: Cache npm (incl ganache-cli/node_modules)
-      uses: actions/cache@v2
-      with:
-        path: |
-          ~/.npm
-          depends/ganache-cli/node_modules
-        key: check-contracts-npm-${{ hashFiles('**/package-lock.json') }}-${{ runner.os }}
     - name: Cache pip
       uses: actions/cache@v2
       with:

README.md

@@ -106,17 +106,7 @@ https://eprint.iacr.org/2016/260).
 #### Terminal 2: Ethereum testnet
 
 ```bash
-# Start the Ethereum test net by running the following commands
-cd zeth_contracts
-
-# If the install below fails with python errors, try running:
-npm config set python python2.7
-
-# Install dependencies
-npm install
-
-# Start a local Ethereum testnet
-npm run testrpc
+scripts/ganache-start
 ```
 
 #### Terminal 3: Python client

scripts/ci

@@ -44,6 +44,7 @@ function check_contracts() {
 
     # Run checks in zeth_contracts
     pushd zeth_contracts
+    npm install
     npm run check
     popd # zeth_contracts
 

scripts/ci_utils.sh

@@ -50,20 +50,8 @@ function server_stop() {
 #
 
 function ganache_setup() {
+    # Nothing to do. Just check that the platform vars have been initialized.
     assert_init_platform
-
-    if [ "${platform}" == "Linux" ] ; then
-        if (which apk) ; then
-            apk add --update npm
-        fi
-    fi
-
-    pushd zeth_contracts
-    npm config set python python2.7
-    npm config set engine-strict true
-    npm config set unsafe-perm true
-    npm install --unsafe-perm
-    popd
 }
 
 function ganache_is_active() {
@@ -75,19 +63,15 @@ function ganache_is_active() {
 }
 
 function ganache_start() {
-    pushd zeth_contracts
     server_start \
-        "npm run testrpc" \
+        scripts/ganache-start \
         ganache_is_active \
         ganache.pid \
         ganache.stdout
-    popd
 }
 
 function ganache_stop() {
-    pushd zeth_contracts
     server_stop ganache ganache.pid
-    popd
 }
 
 #

scripts/ganache-start

@@ -0,0 +1,14 @@
+#!/usr/bin/env bash
+
+echo Starting ganache docker container.  Press CTRL-C to exit.
+
+# Run ganache from the Docker container, passing in the flags required by the
+# zeth tests.
+docker run \
+       --rm \
+       -p 8545:8545 \
+       ghcr.io/clearmatics/ganache-cli:latest \
+       --hardfork istanbul \
+       --gasLimit 0x3FFFFFFFFFFFF \
+       --gasPrice 1 \
+       --defaultBalanceEther 9000000000

zeth_contracts/package.json

@@ -4,8 +4,6 @@
   "description": "zerocash on Ethereum",
   "main": "truffle.js",
   "scripts": {
-    "install": "ln -s ../../depends/ganache-cli node_modules/ganache-cli && cd node_modules/ganache-cli && npm install",
-    "testrpc": "node node_modules/ganache-cli/cli.js --hardfork istanbul --port 8545 --gasLimit 0x3FFFFFFFFFFFF --gasPrice 1 --defaultBalanceEther 90000000000 --networkId 1234",
     "compile": "truffle compile",
     "deploy": "truffle deploy",
     "test": "truffle test",
@@ -15,11 +13,6 @@
   "author": "Clearmatics Technologies LTD: Cryptography R&D Department",
   "license": "LGPL-3.0+",
   "dependencies": {
-    "add": "^2.0.6",
-    "ethereumjs-abi": "^0.6.8",
-    "shell-escape": "^0.2.0",
-    "solhint": "^3.3.2",
-    "strip-hex-prefix": "^1.0.0",
-    "web3": "^1.2.4"
+    "solhint": "^3.3.2"
   }
 }