Merged
Conversation
dtebbs
changed the title
dtebbs
changed the title
| namespace libsnark | ||
| { | ||
|
|
||
| /// Polynomal type, as a list of coefficients (currently only represents |
Contributor
There was a problem hiding this comment.
Polynomal -> Polynomial
dtebbs
changed the title
Contributor
Author
|
@mpzajac flagging this PR in case it is of interest, since it implements a polynomial commitment scheme. Questions or comments welcome. |
|
|
||
| /// The Commit function from [KZG10] section 3.2. Commit to a polynomial | ||
| /// \phi, using some srs. | ||
| static commitment commit(const srs &srs, const polynomial<Field> &phi); |
Contributor
There was a problem hiding this comment.
Linking to clearmatics/libfqfft#5, that would be a c_polynomial
Contributor
Author
|
Thanks @AntoineRondelet . These points should be addressed now. |
3 tasks
Contributor
AntoineRondelet
left a comment
AntoineRondelet
left a comment
There was a problem hiding this comment.
Just a few final comments @dtebbs
dtebbs
force-pushed
the
poly-commit
branch
2 times, most recently
from
22d505c to
baa461b
Compare
Contributor
Author
|
Thanks @AntoineRondelet |
AntoineRondelet
approved these changes
Oct 21, 2021
Contributor
AntoineRondelet
left a comment
AntoineRondelet
left a comment
There was a problem hiding this comment.
LGTM, thanks @dtebbs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
native (i.e. not gadgets) polynomial commitment scheme (KZG10).