Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move docker build to separate job #1051

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Move docker build to separate job #1051

merged 2 commits into from
Jun 10, 2024

Conversation

lumaxis
Copy link
Contributor

@lumaxis lumaxis commented May 30, 2024

No description provided.

@netlify Netlify
Copy link

netlify bot commented May 30, 2024 •
edited
Loading

✅ Deploy Preview for blissful-goodall-fa23f6 ready!

Name Link
🔨 Latest commit 3510524
🔍 Latest deploy log https://app.netlify.com/sites/blissful-goodall-fa23f6/deploys/66588d260611c20008525904
😎 Deploy Preview https://deploy-preview-1051--blissful-goodall-fa23f6.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lumaxis lumaxis marked this pull request as ready for review May 30, 2024 14:32
@lumaxis lumaxis requested a review from elrayle May 30, 2024 14:32
This was referenced Jun 5, 2024
Merged
Merged
elrayle
elrayle approved these changes Jun 5, 2024
View reviewed changes
Copy link
Collaborator

@elrayle elrayle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these consistent across repos! Much easier to maintain that way.

@elrayle
Copy link
Collaborator

elrayle commented Jun 5, 2024

NOTE: test doesn't run because it is being replaced by Run Docker build and tests. The branch settings will need to be updated when this is merged to require that action instead. Test that the change works in the service repo before merging this PR.

Related Work:

@lumaxis lumaxis merged commit 450068f into master Jun 10, 2024
6 checks passed
@lumaxis lumaxis deleted the actions-docker-build-job branch June 10, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elrayle elrayle elrayle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lumaxis @elrayle