Update Node to version 14 #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for blissful-goodall-fa23f6 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
qtomlinson
reviewed
Apr 4, 2024
| COPY . /opt/website | ||
| WORKDIR /opt/website | ||
| ARG REACT_APP_SERVER=http://localhost:4000 | ||
| ARG REACT_APP_GA_TRACKINGID | ||
| RUN apk add --no-cache git | ||
| RUN npm install -g npm@9 |
There was a problem hiding this comment.
Any reason to use npm v9? package-lock.json has "lockfileVersion": 1
There was a problem hiding this comment.
It's significantly faster! ⚡
Compare ~7 minutes on the old version vs. 47s on npm 9
(Both Node 10 and 14 come bundled with npm 6.14.12)
qtomlinson
approved these changes
Apr 17, 2024
| COPY . /opt/website | ||
| WORKDIR /opt/website | ||
| ARG REACT_APP_SERVER=http://localhost:4000 | ||
| ARG REACT_APP_GA_TRACKINGID | ||
| RUN apk add --no-cache git | ||
| RUN npm install -g npm@9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While being far from current, Node 14 is the latest version we can use without having to make further updates to dependencies or code. The changes in this PR don't cause any build errors so it'd be an easy step to get us at least a little closer to running a still-supported version.