Fix NoAssertion cases in maven and sourcearchive typed packages #1017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When processing scancode result, license information is first derived from package level data. When this is not available, ScanCodeSummarizer goes through the root files to look for license. Filtering for root files is based on case sensitive file path matching. In maven packaging, META/INF directory is the standard (see https://issues.apache.org/jira/browse/MJAR-73?attachmentOrder=desc, and https://issues.apache.org/jira/browse/MEAR-30). Change the location for maven to reflect the casing. utils.getLicenseLocations is also used in utils.isLicenseFile. isLicenseFile uses case insensitive matching. Preserve this case insensitive file path matching by converting the result from getLicenseLocations to lowercase there. Test case: https://clearlydefined.io/definitions/maven/mavencentral/org.flywaydb/flyway-core/9.20.0 https://dev.clearlydefined.io/definitions/maven/mavencentral/org.flywaydb/flyway-core/7.7.2 Task: clearlydefined#846
Collaborator
Author
|
@jeffwilcox @JamieMagee @elrayle The maven fix was split from the draft PR. Ready for review. |
elrayle
approved these changes
Nov 27, 2023
Collaborator
elrayle
left a comment
elrayle
left a comment
There was a problem hiding this comment.
LGTM! It's going to be great to have a chunk of the NOASSERTIONs cleared up. Thanks for putting in this fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.