-
Notifications
You must be signed in to change notification settings - Fork 34
Upgrading scancode to v32.4.1 and adding dev notes #650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
JustinGOSSES
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
|
thanks - let's def. get sign-off from @elrayle too |
|
@qtomlinson @jeffmendoza Did you see this PR? |
|
|
||
| The quickest way to get a fully functional local ClearlyDefined set up (including the crawler) is to use the [Dockerized ClearlyDefined environment setup](https://github.com/clearlydefined/docker_dev_env_experiment). This runs all services locally and does not require access to the ClearlyDefined Azure account. | ||
|
|
||
| **THIS IS THE SUGGEST DEV WORKFLOW AS LOCAL INSTALL/SETUP IS VERY ANGRY RIGHT NOW.** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you try running in the context of https://github.com/clearlydefined/docker_dev_env_experiment. That is the easiest way to run any of the three major apps, i.e. service, website, and crawler, on localhost.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep yep, I did and it was the only way I could get the whole system working for me which is why I added the note.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To simulate Azure queue/blob store, see Azurite setup at https://github.com/clearlydefined/docker_dev_env_experiment#additional-setup-to-simulate-deployment-optional.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible for mark Alternative Setup as Legacy?
|
Thanks for the awesome contribution! Glad to see that it addresses the existing issues! Is it possible to run a suite of sanity tests on your local crawler to verify results for various supported components? This will help us to detect any changes in harvest results. Steps for Sanity/Integration Test to Verify Harvest Results:
|
this updates the version of scancode in use in production because the v32.1.0 version will incorrectly identify packages with and LGPL license when it isn't present.
v32.4.1 functions as expected and passes all existing tests.
also added some notes about the version of node you have to use to get
npm installand the tests to function correctly when running locally as well as guidance for people to use the docker env for dev.