Skip to content

Conversation

@jamesiri
Copy link
Contributor

this updates the version of scancode in use in production because the v32.1.0 version will incorrectly identify packages with and LGPL license when it isn't present.

v32.4.1 functions as expected and passes all existing tests.

Screenshot 2025-08-26 at 16 03 47

also added some notes about the version of node you have to use to get npm install and the tests to function correctly when running locally as well as guidance for people to use the docker env for dev.

@jamesiri
Copy link
Contributor Author

jamesiri commented Aug 27, 2025

this shoudl fix #636, #618, #583, and #502

Copy link

@JustinGOSSES JustinGOSSES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jeffwilcox
Copy link
Contributor

thanks - let's def. get sign-off from @elrayle too

@jamesiri jamesiri merged commit ea0a8fe into master Aug 27, 2025
2 checks passed
@jamesiri jamesiri deleted the scancodeUpgrade branch August 27, 2025 22:08
@jamesiri jamesiri restored the scancodeUpgrade branch August 27, 2025 22:08
@elrayle
Copy link
Collaborator

elrayle commented Aug 28, 2025

@qtomlinson @jeffmendoza Did you see this PR?


The quickest way to get a fully functional local ClearlyDefined set up (including the crawler) is to use the [Dockerized ClearlyDefined environment setup](https://github.com/clearlydefined/docker_dev_env_experiment). This runs all services locally and does not require access to the ClearlyDefined Azure account.

**THIS IS THE SUGGEST DEV WORKFLOW AS LOCAL INSTALL/SETUP IS VERY ANGRY RIGHT NOW.**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you try running in the context of https://github.com/clearlydefined/docker_dev_env_experiment. That is the easiest way to run any of the three major apps, i.e. service, website, and crawler, on localhost.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep yep, I did and it was the only way I could get the whole system working for me which is why I added the note.

Copy link
Collaborator

@qtomlinson qtomlinson Aug 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible for mark Alternative Setup as Legacy?

@qtomlinson
Copy link
Collaborator

qtomlinson commented Aug 28, 2025

Thanks for the awesome contribution! Glad to see that it addresses the existing issues! Is it possible to run a suite of sanity tests on your local crawler to verify results for various supported components? This will help us to detect any changes in harvest results.

Steps for Sanity/Integration Test to Verify Harvest Results:

  1. Clone the operations repository:

    git clone https://github.com/clearlydefined/operations/
    
  2. Navigate to the tools/integration directory:

    cd operations/tools/integration
    
  3. Set the process.env.DEV_API_BASE_URL environment variable to point to the local test API service.

  4. Run the end-to-end harvest test:

    npm run e2e-test-harvest
    

    This command will trigger the harvest of a set of components (as defined in componentsStatic in testConfig.js) using the service pointed by DEV_API_BASE_URL. Wait until the harvest process is complete.

  5. Run the end-to-end definition test:

    npm run e2e-test-definition
    

    This command compares the definitions computed on the test API service with those on the production deployment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants