Merged
Conversation
Collaborator
|
Task: #536 |
lumaxis
approved these changes
Feb 21, 2024
elrayle
approved these changes
Feb 21, 2024
Collaborator
elrayle
left a comment
elrayle
left a comment
There was a problem hiding this comment.
LGTM! Great to see another dependency updated. Thanks for the very thorough analysis.
Collaborator
|
@yashkohli88 @qtomlinson This looks ready to merge. Any reason to hold off? |
Collaborator
|
@elrayle Upon merging of the PR, integration tests need to be upgraded to prevent failure. This is work to be reviewed: clearlydefined/operations#80 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated Dockerfile and DevDockerfile in order to update licensee which is one of the scanning tool that crawler uses from version 9.12.0 to 9.16.1. Ruby is also updated from 2.5.4 to 3.2.2. Details for this update can be found https://github.com/clearlydefined/crawler/issues/536