Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test description for rapid and nc scaling tests. #278

Closed
wants to merge 1 commit into from
Closed

Update test description for rapid and nc scaling tests. #278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions metrics/scaling/k8s_scale_nc.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,8 +437,8 @@ help()
usage=$(cat << EOF
Usage: $0 [-h] [options]
Description:
Launch a series of workloads and take memory metric measurements after
each launch.
Launch a series of workloads and take pod query-response latency measurements
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO query-response can be redundant, latency in most of the cases refers to the time that something takes to response.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've taken this description from the ongoing PR212 of such test.

@askervin any thoughts on this?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think query-response is fine (although you may wish to add 'http' or whatever protocol is being used to it). Without saying query-response, then I don't think we'd know which latency was being measured (network, boot, etc.).

after each launch.
Options:
-h, Help page.
EOF
Expand Down
4 changes: 2 additions & 2 deletions metrics/scaling/k8s_scale_rapid.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,8 +211,8 @@ help()
usage=$(cat << EOF
Usage: $0 [-h] [options]
Description:
Launch a series of workloads and take memory metric measurements after
each launch.
Launch a series of workloads and take memory metric measurements using 'collectd'
after each launch.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact, we don't just take memory measurements any more - I think saying a set of system level measurements using collected will now be more accurate.

Options:
-h, Help page.
EOF
Expand Down