Skip to content

Updated torch n_jobs=1 #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 13, 2023
Merged

Updated torch n_jobs=1 #156

merged 3 commits into from
Apr 13, 2023

Conversation

sanjanag
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Merging #156 (5e57788) into main (2ee3242) will increase coverage by 0.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #156      +/-   ##
==========================================
+ Coverage   93.32%   93.45%   +0.12%     
==========================================
  Files          14       14              
  Lines         839      840       +1     
  Branches      156      156              
==========================================
+ Hits          783      785       +2     
+ Misses         35       34       -1     
  Partials       21       21              
Impacted Files Coverage Δ
...ion/issue_managers/image_property_issue_manager.py 95.12% <ø> (-0.08%) ⬇️
src/cleanvision/imagelab.py 89.13% <100.00%> (+0.30%) ⬆️
...anvision/issue_managers/duplicate_issue_manager.py 95.61% <100.00%> (-0.08%) ⬇️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sanjanag sanjanag marked this pull request as ready for review April 12, 2023 16:50
@sanjanag sanjanag requested a review from jwmueller April 12, 2023 16:50
@sanjanag sanjanag linked an issue Apr 12, 2023 that may be closed by this pull request
Copy link
Member

@jwmueller jwmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a couple questions/suggestions

@sanjanag sanjanag self-assigned this Apr 13, 2023
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@jwmueller jwmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Don't forget to update the cleanvision-examples notebooks too

@jwmueller jwmueller merged commit 4eec800 into cleanlab:main Apr 13, 2023
@sanjanag sanjanag deleted the torch-njobs branch April 15, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Torch data loaders interfere with cleanvision parallelization
2 participants