Skip to content

Bugfix #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 31, 2023
Merged

Bugfix #143

merged 3 commits into from
Mar 31, 2023

Conversation

sanjanag
Copy link
Contributor

@sanjanag sanjanag commented Mar 30, 2023

  • Fixed bug for Windows OS where image files were getting picked up twice.
  • Added testing in CI for Windows and MacOS.

@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Merging #143 (2e5195b) into main (b302e8d) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #143      +/-   ##
==========================================
+ Coverage   91.85%   91.87%   +0.02%     
==========================================
  Files           9        9              
  Lines         761      763       +2     
  Branches      147      147              
==========================================
+ Hits          699      701       +2     
  Misses         41       41              
  Partials       21       21              
Impacted Files Coverage Δ
src/cleanvision/utils/constants.py 100.00% <100.00%> (ø)
src/cleanvision/utils/utils.py 89.58% <100.00%> (+0.22%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sanjanag sanjanag self-assigned this Mar 30, 2023
@sanjanag sanjanag requested a review from jwmueller March 30, 2023 22:32
@sanjanag sanjanag marked this pull request as ready for review March 30, 2023 22:32
Copy link
Member

@jwmueller jwmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff!

@jwmueller
Copy link
Member

Closes #141

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Files loaded twice when image folder has images with .jpeg or .png extensions.
2 participants