Add better structured outputs handling for ChatCompletions #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eceive LOW SCORE.
jwmueller
reviewed
Jul 14, 2025
| @@ -5,8 +5,10 @@ | |||
| It works for any OpenAI LLM model, as well as the many other non-OpenAI LLMs that are also usable via Chat Completions API (Gemini, DeepSeek, Llama, etc). | |||
There was a problem hiding this comment.
In VPC, what will be the recommended way to score:
- tool calls
- structured outputs
?
jas2600
reviewed
Jul 14, 2025
jas2600
reviewed
Jul 17, 2025
|
|
||
| await handle_api_key_error_from_resp(res) | ||
| await handle_http_bad_request_error_from_resp(res) | ||
| handle_rate_limit_error_from_resp(res) |
There was a problem hiding this comment.
this check can be placed above the await res.json() so in some scenarios It avoids an unnecessary attempt to parse the response body if the http status is already rate limit
jas2600
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key Info
Branching off #93 for now to minimize changes / conflict
What changed?
What do you want the reviewer(s) to focus on?
Checklist